SIMD-0185: Vote Account v4 #185
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstarry
force-pushed
the
vote-account-v4
branch
from
3fc627d
to
9d8dedb
Compare
buffalu
reviewed
Oct 18, 2024
| pub block_fees_collector: Pubkey, | ||
| pub block_tips_collector: Pubkey, | ||
|
|
||
| /// NEW: percentages (0-100) that represent how much of each income source |
There was a problem hiding this comment.
Yeah I considered that but it seems like even jito mev tip commissions are usually just integer percentages?
AshwinSekar
reviewed
Oct 18, 2024
| `authorized_voters` field that correspond to epochs less than the current epoch, | ||
| only purge entries less than the previous epoch (current epoch - 1). This will | ||
| mean that the `authorized_voters` field can now hold up to 4 entries for the | ||
| epochs in the range `[current_epoch - 1, current_epoch + 2]`. Keeping the |
There was a problem hiding this comment.
is there a reason we need to store current_epoch + 2?
There was a problem hiding this comment.
Yeah that's the current design and I think it kinda makes sense because otherwise you could set a new authorized voter at the end of an epoch and immediately start using it in the next block in the new epoch and leaders would need an up to date view on any new authorized voters for each fork crossing the epoch boundary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.