Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basics/favorites/poseidon #195

Merged
merged 10 commits into from
Jan 2, 2025

Conversation

mwaa
Copy link
Contributor

@mwaa mwaa commented Oct 22, 2024

Adds the poseidon implementation of favorites with a replication of existing favorite data types.

@mwaa mwaa closed this Oct 23, 2024
@mwaa mwaa reopened this Oct 23, 2024
@heyAyushh heyAyushh added contribute:poseidon Adds a poseidon example contribution to the repository. favourites basics/favourites labels Nov 15, 2024
Copy link
Member

@heyAyushh heyAyushh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your submission! To verify the technical implementation, please complete these steps:

  1. Merge the main branch into your PR to get the latest updates
  2. Run pnpm fix at the project root for consistent code style
  3. Ensure your implementation includes:
    • Transpiled Anchor program in the programs folder
    • TypeScript files in the ts-programs folder
  4. Run poseidon sync to synchronize program ID and keys
  5. Run cargo fmt and cargo clippy for Rust code quality
  6. Push your changes

Please note: This review is to verify technical completeness of the submission

Let me know once you've completed these steps and I'll review again. Thanks!

@mwaa
Copy link
Contributor Author

mwaa commented Nov 25, 2024

@heyAyushh I have update my branch as per your recommendations above. You may proceed with the review.

Please note for poseidon sync has a bug which i have reported here Turbin3/poseidon#38

@mwaa
Copy link
Contributor Author

mwaa commented Dec 4, 2024

@heyAyushh you can review once more. I update the typescript program to reflect changes in poseidon

@heyAyushh heyAyushh merged commit 2a97efb into solana-developers:main Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribute:poseidon Adds a poseidon example contribution to the repository. favourites basics/favourites
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants