-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding bankrun context wrapper #41
Closed
heyAyushh
wants to merge
24
commits into
solana-developers:main
from
heyAyushh:bankrun-context-helper
Closed
adding bankrun context wrapper #41
heyAyushh
wants to merge
24
commits into
solana-developers:main
from
heyAyushh:bankrun-context-helper
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikemaccana
suggested changes
Aug 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a large PR with a lot of unrelated work. In general, use one PR for each change you're going to make - that way they can be reviewed, merged, and (if needed) reverted separately.
Please split this work into multiple PRs.
- The build changes to support CommonJS libraries
- Adding a bankrun helper
- Reorganizing the code into multiple files
- Ignoring node's test runner for ts-jest - we want to avoid adding unnecessary dependencies, so in whatever PR you made that adds ts-jest, state why you're adding it (or if there's no specific reason, don't add that PRs)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BankrunContextWrapper
wrapper is needed so that we can useconnection
object in anchor-bankrun or solana-bankrun