Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding bankrun context wrapper #41

Closed

Conversation

heyAyushh
Copy link
Contributor

@heyAyushh heyAyushh commented Aug 21, 2024

  • This BankrunContextWrapper wrapper is needed so that we can use connection object in anchor-bankrun or solana-bankrun
  • refactored functions into logical files
  • changed build steps to include cjs along with esm module
  • introduced testing with ts-jest
  • fixed type definitions not found

Copy link
Contributor

@mikemaccana mikemaccana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a large PR with a lot of unrelated work. In general, use one PR for each change you're going to make - that way they can be reviewed, merged, and (if needed) reverted separately.

Please split this work into multiple PRs.

  • The build changes to support CommonJS libraries
  • Adding a bankrun helper
  • Reorganizing the code into multiple files
  • Ignoring node's test runner for ts-jest - we want to avoid adding unnecessary dependencies, so in whatever PR you made that adds ts-jest, state why you're adding it (or if there's no specific reason, don't add that PRs)

@heyAyushh heyAyushh closed this Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants