Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: save address to env file too #31

Merged
merged 1 commit into from
Mar 22, 2024
Merged

Conversation

nickfrosty
Copy link
Member

Updated the addKeypairToEnvFile function to also add a comment to the env file with the pubkey address that was saved

@nickfrosty nickfrosty changed the title feat: save address feat: save address to env file too Mar 22, 2024
@mikemaccana
Copy link
Contributor

Heya! @aitimate suggested this in #24 but I had some concerns.

@nickfrosty
Copy link
Member Author

I don't see this "getting out of sync" as a concern since the helpers generates both lines and saves it to the env file.

If a person edits their env file, then that's on them to update the associated comment line above it

@mikemaccana
Copy link
Contributor

If a person edits their env file, then that's on them to update the associated comment line above it

That's fair enough. merged!

@mikemaccana mikemaccana merged commit 0e36801 into main Mar 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants