Skip to content

Comments

Remove url.full from default OpenTelemetry metrics attributes#2815

Merged
adamw merged 1 commit intomasterfrom
remove-url-full-from-default-otel-metrics
Feb 19, 2026
Merged

Remove url.full from default OpenTelemetry metrics attributes#2815
adamw merged 1 commit intomasterfrom
remove-url-full-from-default-otel-metrics

Conversation

@adamw
Copy link
Member

@adamw adamw commented Feb 19, 2026

Summary

  • Remove url.full from default OpenTelemetry metrics request attributes to avoid high-cardinality metric explosion
  • Users who need the full URL can opt in via OpenTelemetryDefaults.requestAttributesWithFullUrl
  • Add tests verifying url.full is absent by default and present when explicitly opted in

Test plan

  • Verify new tests pass: default attributes exclude url.full, requestAttributesWithFullUrl includes it

🤖 Generated with Claude Code

Copilot AI review requested due to automatic review settings February 19, 2026 14:43
The full URL is a high-cardinality attribute that can cause metric
explosion. Remove it from the default request attributes while keeping
it available via requestAttributesWithFullUrl for users who need it.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@adamw adamw force-pushed the remove-url-full-from-default-otel-metrics branch from 88cc9d0 to 7e91018 Compare February 19, 2026 14:50
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request removes the url.full attribute from the default OpenTelemetry metrics to prevent high-cardinality metric explosion, while maintaining backward compatibility through an opt-in method. Additionally, it includes new development container infrastructure for sandboxed development.

Changes:

  • Remove url.full from default OpenTelemetry metrics request attributes to avoid high-cardinality issues
  • Add tests verifying the default behavior excludes url.full and the opt-in requestAttributesWithFullUrl includes it
  • Add comprehensive devcontainer setup with mitmproxy network proxy and WireGuard tunnel for sandboxed development

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Show a summary per file
File Description
observability/opentelemetry-backend/src/main/scala/sttp/client4/opentelemetry/OpenTelemetryDefaults.scala Removed url.full from default requestAttributes method and removed unused Response import
observability/opentelemetry-backend/src/test/scala/sttp/client4/opentelemetry/OpenTelemetryMetricsBackendTest.scala Added tests verifying url.full is absent by default and present when using requestAttributesWithFullUrl
.devcontainer/sandcat/settings.example.json Example settings file for sandcat development environment configuration
.devcontainer/sandcat/scripts/wg-client-init.sh WireGuard client initialization script for network tunnel setup
.devcontainer/sandcat/scripts/mitmproxy_addon.py Mitmproxy addon for network access rules and secret substitution
.devcontainer/sandcat/scripts/app-user-init.sh User-level initialization script for development container setup
.devcontainer/sandcat/scripts/app-post-start.sh Post-start hook to remove forwarded credential sockets
.devcontainer/sandcat/scripts/app-init.sh Main entrypoint for development containers with CA cert installation
.devcontainer/sandcat/compose-proxy.yml Docker Compose configuration for mitmproxy and WireGuard client services
.devcontainer/sandcat/Dockerfile.wg-client Dockerfile for WireGuard client container
.devcontainer/devcontainer.json VS Code devcontainer configuration with security settings
.devcontainer/compose-all.yml Main Docker Compose file integrating proxy and application services
.devcontainer/Dockerfile.app Dockerfile for main application development container

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@adamw adamw merged commit f1aedd9 into master Feb 19, 2026
27 checks passed
@adamw adamw deleted the remove-url-full-from-default-otel-metrics branch February 19, 2026 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant