Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify ResponseException #2397

Merged
merged 14 commits into from
Jan 14, 2025
Merged

Simplify ResponseException #2397

merged 14 commits into from
Jan 14, 2025

Conversation

adamw
Copy link
Member

@adamw adamw commented Jan 13, 2025 •
edited
Loading

  • the parametrization of ResponseException is simplified, DeserializationException does not have a type parameter, always requiring an Exception as the cause instead
  • when a ResponseException is thrown in the response handling specification, this will be logged as a successful response (as the response was received correctly), and counted as a success in the metrics as well
  • HttpError is renamed to UnexpectedStatusCode, and along with DeserializationException, both types are nested within ResponseException

Closes #1097

@adamw adamw changed the title Improve ResponseException handling in logging backend Simplify ResponseException Jan 14, 2025
@adamw adamw merged commit 0a2aaa9 into master Jan 14, 2025
21 checks passed
@adamw adamw deleted the response-exceptions branch January 14, 2025 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

make the OOTB response logs before deserialization
1 participant
@adamw