Unify LS searching logic whether it is scarb project or not. #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Draggu
requested review from
piotmag769 and
integraledelebesgue
and removed request for
a team
Currently depending on if `Scarb.toml` was detected precedence of LS binary from settings ot from scarb is changing, remove this behaviour if favour of more stable one. This is making usage of `cairo1.languageServerPath` and `cairo1.preferScarbLanguageServer` more predictable because it will work same way in scarb and non scarb projects. commit-id:880ce024
Draggu
force-pushed
the
spr/main/880ce024
branch
from
49aad38 to
72e02c1
Compare
piotmag769
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently depending on if
Scarb.tomlwas detected precedence of LS binary from settings ot from scarb is changing, remove this behaviour if favour of more stable one.This is making usage of
cairo1.languageServerPathandcairo1.preferScarbLanguageServermore predictable because it will work same way in scarb and non scarb projects.Stack: