Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(windows): svg erroring with navigation call #2630

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

TatianaKapos
Copy link

@TatianaKapos TatianaKapos commented Feb 7, 2025

Summary

  • Adds check for correct width/height in SVGView in Paper implementation. This fixes navigation.navigate() call
  • Switches paper-windows-example to use navigation example app.
  • Upgrade paper-windows-example to 0.76.
  • Adds checks for unsupported modules in windows for navigation app.

Resolves #2569

Test Plan

Tested locally with navigation example app on windows
ApplicationFrameHost_aIKuInJ4f0

Compatibility

OS Implemented
iOS
MacOS
Android
Web

Checklist

  • I have tested this on a device and a simulator
  • I added documentation in README.md
  • I updated the typed files (typescript)
  • I added a test for the API in the __tests__ folder

@TatianaKapos TatianaKapos changed the title [Draft] Fix svg with navigation on windows Fix(windows): svg erroring with navigation call Feb 7, 2025
@TatianaKapos TatianaKapos marked this pull request as ready for review February 7, 2025 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

react-native-window app crash when rendering svg as component and firing navigation.navigate
1 participant