Skip to content

Commit

Permalink
fix: FeDropShadow results and import react (#2625)
Browse files Browse the repository at this point in the history
# Summary

* Add results alias in `FeDropShadow`
* Import React in every tsx filter file to satisfy typescript/eslint
* Replace `<>` with `<React.Fragment>` in `FeDropShadow`
  • Loading branch information
jakex7 authored Jan 24, 2025
1 parent 04d0e89 commit e79a6c1
Show file tree
Hide file tree
Showing 12 changed files with 22 additions and 11 deletions.
1 change: 1 addition & 0 deletions src/elements/filters/FeBlend.tsx
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import React from 'react';
import { NativeMethods } from 'react-native';
import {
extractFeBlend,
Expand Down
2 changes: 1 addition & 1 deletion src/elements/filters/FeColorMatrix.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import * as React from 'react';
import React from 'react';
import { NativeMethods } from 'react-native';
import RNSVGFeColorMatrix from '../../fabric/FeColorMatrixNativeComponent';
import {
Expand Down
2 changes: 1 addition & 1 deletion src/elements/filters/FeComponentTransfer.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import * as React from 'react';
import React from 'react';
import FilterPrimitive from './FilterPrimitive';
import { warnUnimplementedFilter } from '../../lib/util';

Expand Down
1 change: 1 addition & 0 deletions src/elements/filters/FeComponentTransferFunction.tsx
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import React from 'react';
import { NumberArray, NumberProp } from '../../lib/extract/types';
import { warnUnimplementedFilter } from '../../lib/util';
import FilterPrimitive from './FilterPrimitive';
Expand Down
1 change: 1 addition & 0 deletions src/elements/filters/FeComposite.tsx
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import React from 'react';
import { NativeMethods } from 'react-native';
import RNSVGFeComposite from '../../fabric/FeCompositeNativeComponent';
import {
Expand Down
15 changes: 11 additions & 4 deletions src/elements/filters/FeDropShadow.tsx
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import React from 'react';
import { ColorValue } from 'react-native';
import { NumberArray, NumberProp } from '../../lib/extract/types';
import FeFlood from './FeFlood';
Expand Down Expand Up @@ -25,21 +26,27 @@ export default class FeDropShadow extends FilterPrimitive<FeDropShadowProps> {
};

render() {
const { stdDeviation, in: in1 = 'SourceGraphic', dx, dy } = this.props;
const {
stdDeviation,
in: in1 = 'SourceGraphic',
dx,
dy,
result,
} = this.props;
return (
<>
<React.Fragment>
<FeGaussianBlur in={in1} stdDeviation={stdDeviation} />
<FeOffset dx={dx} dy={dy} result="offsetblur" />
<FeFlood
floodColor={this.props.floodColor}
floodOpacity={this.props.floodOpacity}
/>
<FeComposite in2="offsetblur" operator="in" />
<FeMerge>
<FeMerge result={result}>
<FeMergeNode />
<FeMergeNode in={in1} />
</FeMerge>
</>
</React.Fragment>
);
}
}
1 change: 1 addition & 0 deletions src/elements/filters/FeFlood.tsx
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import React from 'react';
import { ColorValue, NativeMethods } from 'react-native';
import RNSVGFeFlood from '../../fabric/FeFloodNativeComponent';
import extractFeFlood, { extractFilter } from '../../lib/extract/extractFilter';
Expand Down
2 changes: 1 addition & 1 deletion src/elements/filters/FeGaussianBlur.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import * as React from 'react';
import React from 'react';
import { NativeMethods } from 'react-native';
import RNSVGFeGaussianBlur from '../../fabric/FeGaussianBlurNativeComponent';
import {
Expand Down
2 changes: 1 addition & 1 deletion src/elements/filters/FeMerge.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import * as React from 'react';
import React from 'react';
import { NativeMethods } from 'react-native';
import RNSVGFeMerge from '../../fabric/FeMergeNativeComponent';
import { extractFeMerge, extractFilter } from '../../lib/extract/extractFilter';
Expand Down
2 changes: 1 addition & 1 deletion src/elements/filters/FeMergeNode.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import * as React from 'react';
import React from 'react';
import FilterPrimitive from './FilterPrimitive';

export interface FeMergeNodeProps {
Expand Down
2 changes: 1 addition & 1 deletion src/elements/filters/FeOffset.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import * as React from 'react';
import React from 'react';
import { NativeMethods } from 'react-native';
import RNSVGFeOffset from '../../fabric/FeOffsetNativeComponent';
import { extractFilter, extractIn } from '../../lib/extract/extractFilter';
Expand Down
2 changes: 1 addition & 1 deletion src/elements/filters/Filter.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import * as React from 'react';
import React from 'react';
import { NativeMethods } from 'react-native';
import RNSVGFilter from '../../fabric/FilterNativeComponent';
import { NumberProp, Units } from '../../lib/extract/types';
Expand Down

0 comments on commit e79a6c1

Please sign in to comment.