Conversation
|
pkg.pr.new packages benchmark commit |
📊 Bundle Size Comparison
👀 Notable resultsStatic test results:No major changes. Dynamic test results:No major changes. 📋 All resultsClick to reveal the results table (344 entries).
If you wish to run a comparison for other, slower bundlers, run the 'Tree-shake test' from the GitHub Actions menu. |
bf4a3b7 to
0a92414
Compare
There was a problem hiding this comment.
Pull request overview
This PR migrates the repo’s formatting workflow from Deno formatting to oxfmt, updating ignore directives/config and reformatting a large portion of the codebase to the new style.
Changes:
- Added
.oxfmtrc.jsonand updated in-code ignore directives to// oxfmt-ignore. - Reformatted TypeScript/JavaScript/JSON/HTML/CSS across packages and docs to match oxfmt output.
- Removed Deno formatting setup from editor/CI bits (VSCode settings, GitHub workflows) as part of the migration.
Reviewed changes
Copilot reviewed 292 out of 609 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/typegpu-noise/src/perlin-3d/algorithm.ts | oxfmt reformat |
| packages/typegpu-noise/src/perlin-2d/static-cache.ts | oxfmt reformat |
| packages/typegpu-noise/src/perlin-2d/algorithm.ts | oxfmt reformat |
| packages/typegpu-noise/src/generator.ts | oxfmt reformat |
| packages/typegpu-noise/package.json | package.json formatting/ordering updates |
| packages/typegpu-noise/README.md | markdown formatting update |
| packages/typegpu-geometry/src/lines/joins/round.ts | oxfmt reformat |
| packages/typegpu-geometry/src/lines/joins/miter.ts | oxfmt reformat |
| packages/typegpu-geometry/src/lines/joins/common.ts | oxfmt reformat |
| packages/typegpu-geometry/src/lines/indices.ts | migrate ignore comments to oxfmt |
| packages/typegpu-geometry/src/lines/caps/triangle.ts | oxfmt reformat |
| packages/typegpu-geometry/src/lines/caps/swallowtail.ts | oxfmt reformat |
| packages/typegpu-geometry/src/lines/caps/square.ts | oxfmt reformat |
| packages/typegpu-geometry/src/lines/caps/round.ts | oxfmt reformat |
| packages/typegpu-geometry/src/lines/caps/common.ts | oxfmt reformat |
| packages/typegpu-geometry/src/lines/caps/butt.ts | oxfmt reformat |
| packages/typegpu-geometry/src/lines/caps/arrow.ts | oxfmt reformat |
| packages/typegpu-geometry/src/circle.ts | oxfmt reformat |
| packages/typegpu-geometry/package.json | package.json formatting/ordering updates |
| packages/typegpu-concurrent-scan/src/concurrentScan.ts | oxfmt reformat |
| packages/typegpu-concurrent-scan/src/compute/shared.ts | oxfmt reformat |
| packages/typegpu-concurrent-scan/src/compute/scan.ts | oxfmt reformat |
| packages/typegpu-concurrent-scan/package.json | package.json formatting/ordering updates |
| packages/typegpu-concurrent-scan/README.md | markdown formatting update |
| packages/typegpu-color/src/ycbcr.ts | oxfmt reformat |
| packages/typegpu-color/src/srgb.ts | oxfmt reformat |
| packages/typegpu-color/src/hsv.ts | oxfmt reformat |
| packages/typegpu-color/package.json | package.json formatting/ordering updates |
| packages/tinyest/src/nodes.ts | oxfmt reformat |
| packages/tinyest/package.json | package.json formatting/ordering updates |
| packages/tinyest-for-wgsl/tests/parsers.test.ts | oxfmt reformat |
| packages/tgpu-gen/tests/structs.test.ts | oxfmt reformat |
| packages/tgpu-gen/tests/outputPathCompiler.test.ts | oxfmt reformat |
| packages/tgpu-gen/tests/bindGroupLayouts.test.ts | oxfmt reformat |
| packages/tgpu-gen/package.json | package.json formatting/ordering updates |
| packages/tgpu-gen/outputPathCompiler.mjs | oxfmt reformat |
| packages/tgpu-dev-cli/tgpu-dev-cli.mjs | oxfmt reformat |
| packages/tgpu-dev-cli/progress.mjs | oxfmt reformat |
| packages/tgpu-dev-cli/prepack.mjs | oxfmt reformat |
| packages/tgpu-dev-cli/package.json | package.json formatting/ordering updates |
| packages/tgpu-dev-cli/icons.mjs | oxfmt reformat |
| packages/tgpu-dev-cli/changes.mjs | oxfmt reformat |
| packages/eslint-plugin/tests/integerDivision.test.ts | oxfmt reformat |
| packages/eslint-plugin/src/configs.ts | oxfmt reformat |
| packages/eslint-plugin/package.json | package.json formatting/ordering updates |
| oxlint.config.ts | oxfmt reformat |
| apps/typegpu-docs/vitest.config.mts | oxfmt reformat |
| apps/typegpu-docs/tests/examples.test.browser.ts | oxfmt reformat |
| apps/typegpu-docs/src/utils/useHydrated.ts | oxfmt reformat |
| apps/typegpu-docs/src/utils/useEvent.ts | oxfmt reformat |
| apps/typegpu-docs/src/utils/examples/sandboxModules.ts | oxfmt reformat |
| apps/typegpu-docs/src/utils/examples/exampleViewStateAtoms.ts | oxfmt reformat |
| apps/typegpu-docs/src/utils/examples/exampleRunner.ts | oxfmt reformat |
| apps/typegpu-docs/src/utils/examples/currentSnackbarAtom.ts | oxfmt reformat |
| apps/typegpu-docs/src/pages/benchmark/test-suites/compiled-write.ts | oxfmt reformat |
| apps/typegpu-docs/src/pages/benchmark/suites.ts | oxfmt reformat |
| apps/typegpu-docs/src/pages/benchmark/parameter-set.ts | oxfmt reformat |
| apps/typegpu-docs/src/pages/benchmark/modules.ts | oxfmt reformat |
| apps/typegpu-docs/src/pages/benchmark/atom-with-url.ts | oxfmt reformat |
| apps/typegpu-docs/src/fonts/font-face.css | oxfmt reformat |
| apps/typegpu-docs/src/examples/threejs/varyings/index.ts | oxfmt reformat |
| apps/typegpu-docs/src/examples/threejs/test-reused-functions/index.ts | oxfmt reformat |
| apps/typegpu-docs/src/examples/threejs/test-reused-functions/cubes.ts | oxfmt reformat |
| apps/typegpu-docs/src/examples/threejs/test-mismatched-types/index.ts | oxfmt reformat |
| apps/typegpu-docs/src/examples/threejs/simple/index.ts | oxfmt reformat |
| apps/typegpu-docs/src/examples/threejs/compute-particles-snow/entities.ts | oxfmt reformat |
| apps/typegpu-docs/src/examples/threejs/compute-cloth/triNoise.ts | oxfmt reformat |
| apps/typegpu-docs/src/examples/tests/uniformity/prngs.ts | oxfmt reformat |
| apps/typegpu-docs/src/examples/tests/uniformity/lcg.ts | oxfmt reformat |
| apps/typegpu-docs/src/examples/tests/uniformity/index.ts | oxfmt reformat |
| apps/typegpu-docs/src/examples/tests/tgsl-parsing-test/pointers.ts | oxfmt reformat |
| apps/typegpu-docs/src/examples/tests/tgsl-parsing-test/index.ts | oxfmt reformat |
| apps/typegpu-docs/src/examples/tests/texture-test/index.ts | oxfmt reformat |
| apps/typegpu-docs/src/examples/tests/prefix-scan/functions.ts | oxfmt reformat |
| apps/typegpu-docs/src/examples/tests/copy-error/index.ts | oxfmt reformat |
| apps/typegpu-docs/src/examples/tests/copy-error/index.html | html formatting update |
| apps/typegpu-docs/src/examples/simulation/stable-fluid/render.ts | oxfmt reformat |
| apps/typegpu-docs/src/examples/simulation/gravity/schemas.ts | oxfmt reformat |
| apps/typegpu-docs/src/examples/simulation/gravity/render.ts | oxfmt reformat |
| apps/typegpu-docs/src/examples/simulation/gravity/presets.ts | oxfmt reformat |
| apps/typegpu-docs/src/examples/simulation/gravity/helpers.ts | oxfmt reformat |
| apps/typegpu-docs/src/examples/simulation/game-of-life/shaders/tiled-compute.ts | oxfmt reformat + ignore directive update |
| apps/typegpu-docs/src/examples/simulation/game-of-life/shaders/naive-compute.ts | oxfmt reformat |
| apps/typegpu-docs/src/examples/simulation/game-of-life/shaders/common.ts | oxfmt reformat |
| apps/typegpu-docs/src/examples/simulation/game-of-life/shaders/bitpacked-compute.ts | oxfmt reformat + ignore directive update |
| apps/typegpu-docs/src/examples/simulation/game-of-life/input.ts | oxfmt reformat |
| apps/typegpu-docs/src/examples/simulation/confetti/index.ts | oxfmt reformat |
| apps/typegpu-docs/src/examples/simulation/boids/index.ts | oxfmt reformat |
| apps/typegpu-docs/src/examples/simple/vaporrave/sphere.ts | oxfmt reformat |
| apps/typegpu-docs/src/examples/simple/vaporrave/meta.json | json formatting update |
| apps/typegpu-docs/src/examples/simple/vaporrave/index.ts | oxfmt reformat |
| apps/typegpu-docs/src/examples/simple/vaporrave/helpers.ts | oxfmt reformat |
| apps/typegpu-docs/src/examples/simple/vaporrave/floor.ts | oxfmt reformat |
| apps/typegpu-docs/src/examples/simple/triangle/index.ts | oxfmt reformat |
| apps/typegpu-docs/src/examples/simple/triangle-next/index.ts | oxfmt reformat |
| apps/typegpu-docs/src/examples/simple/stencil/index.ts | oxfmt reformat |
| apps/typegpu-docs/src/examples/simple/square/index.ts | oxfmt reformat |
| apps/typegpu-docs/src/examples/simple/ripple-cube/sdf-scene.ts | oxfmt reformat |
| apps/typegpu-docs/src/examples/simple/ripple-cube/pbr.ts | oxfmt reformat |
| apps/typegpu-docs/src/examples/simple/gradient-tiles/index.ts | oxfmt reformat |
| apps/typegpu-docs/src/examples/rendering/xor-dev-runner/index.html | html formatting update |
| apps/typegpu-docs/src/examples/rendering/xor-dev-centrifuge-2/index.ts | oxfmt reformat |
| apps/typegpu-docs/src/examples/rendering/xor-dev-centrifuge-2/index.html | html formatting update |
| apps/typegpu-docs/src/examples/rendering/ray-marching/meta.json | json formatting update |
| apps/typegpu-docs/src/examples/rendering/point-light-shadow/types.ts | oxfmt reformat |
| apps/typegpu-docs/src/examples/rendering/point-light-shadow/scene.ts | oxfmt reformat |
| apps/typegpu-docs/src/examples/rendering/point-light-shadow/point-light.ts | oxfmt reformat |
| apps/typegpu-docs/src/examples/rendering/point-light-shadow/camera.ts | oxfmt reformat |
| apps/typegpu-docs/src/examples/rendering/point-light-shadow/box-geometry.ts | oxfmt reformat |
| apps/typegpu-docs/src/examples/rendering/phong-reflection/load-model.ts | oxfmt reformat |
| apps/typegpu-docs/src/examples/rendering/phong-reflection/index.ts | oxfmt reformat |
| apps/typegpu-docs/src/examples/rendering/perlin-noise/index.ts | oxfmt reformat |
| apps/typegpu-docs/src/examples/rendering/jelly-switch/utils.ts | oxfmt reformat |
| apps/typegpu-docs/src/examples/rendering/jelly-switch/switch.ts | oxfmt reformat |
| apps/typegpu-docs/src/examples/rendering/jelly-switch/camera.ts | oxfmt reformat |
| apps/typegpu-docs/src/examples/rendering/jelly-slider/utils.ts | oxfmt reformat |
| apps/typegpu-docs/src/examples/rendering/jelly-slider/numbers.ts | oxfmt reformat |
| apps/typegpu-docs/src/examples/rendering/jelly-slider/index.html | html formatting update |
| apps/typegpu-docs/src/examples/rendering/jelly-slider/events.ts | oxfmt reformat |
| apps/typegpu-docs/src/examples/rendering/jelly-slider/camera.ts | oxfmt reformat |
| apps/typegpu-docs/src/examples/rendering/disco/utils.ts | oxfmt reformat |
| apps/typegpu-docs/src/examples/rendering/disco/index.ts | oxfmt reformat |
| apps/typegpu-docs/src/examples/rendering/clouds/index.ts | oxfmt reformat |
| apps/typegpu-docs/src/examples/rendering/caustics/index.ts | oxfmt reformat |
| apps/typegpu-docs/src/examples/rendering/3d-fish/tgsl-helpers.ts | oxfmt reformat |
| apps/typegpu-docs/src/examples/rendering/3d-fish/schemas.ts | oxfmt reformat |
| apps/typegpu-docs/src/examples/rendering/3d-fish/render.ts | oxfmt reformat |
| apps/typegpu-docs/src/examples/rendering/3d-fish/load-model.ts | oxfmt reformat |
| apps/typegpu-docs/src/examples/rendering/3d-fish/index.html | html formatting update |
| apps/typegpu-docs/src/examples/rendering/3d-fish/compute.ts | oxfmt reformat |
| apps/typegpu-docs/src/examples/image-processing/chroma-keying/index.ts | oxfmt reformat |
| apps/typegpu-docs/src/examples/image-processing/camera-thresholding/index.ts | oxfmt reformat |
| apps/typegpu-docs/src/examples/image-processing/blur/index.ts | oxfmt reformat |
| apps/typegpu-docs/src/examples/image-processing/background-segmentation/shaders.ts | oxfmt reformat |
| apps/typegpu-docs/src/examples/image-processing/background-segmentation/index.html | html formatting update |
| apps/typegpu-docs/src/examples/geometry/circles/index.ts | oxfmt reformat |
| apps/typegpu-docs/src/examples/common/defineControls.ts | oxfmt reformat |
| apps/typegpu-docs/src/examples/algorithms/probability/types.ts | oxfmt reformat |
| apps/typegpu-docs/src/examples/algorithms/probability/index.ts | oxfmt reformat |
| apps/typegpu-docs/src/examples/algorithms/probability/index.html | html formatting update |
| apps/typegpu-docs/src/examples/algorithms/mnist-inference/meta.json | json formatting update |
| apps/typegpu-docs/src/examples/algorithms/mnist-inference/index.html | html/css formatting update |
| apps/typegpu-docs/src/examples/algorithms/mnist-inference/helpers.ts | oxfmt reformat |
| apps/typegpu-docs/src/examples/algorithms/matrix-next/types.ts | oxfmt reformat |
| apps/typegpu-docs/src/examples/algorithms/matrix-next/index.html | html formatting update |
| apps/typegpu-docs/src/examples/algorithms/matrix-next/computeSimple.ts | oxfmt reformat |
| apps/typegpu-docs/src/examples/algorithms/matrix-next/computeCpu.ts | oxfmt reformat |
| apps/typegpu-docs/src/examples/algorithms/matrix-multiplication/index.ts | oxfmt reformat |
| apps/typegpu-docs/src/examples/algorithms/jump-flood-distance/visualization.ts | oxfmt reformat |
| apps/typegpu-docs/src/examples/algorithms/jump-flood-distance/types.ts | oxfmt reformat |
| apps/typegpu-docs/src/examples/algorithms/concurrent-chart/index.ts | oxfmt reformat |
| apps/typegpu-docs/src/examples/algorithms/concurrent-chart/index.html | html/css formatting update |
| apps/typegpu-docs/src/examples/algorithms/concurrent-chart/calculator.ts | oxfmt reformat |
| apps/typegpu-docs/src/content/docs/tutorials/triangle-to-boids/code/step9-webgpu.ts | oxfmt reformat |
| apps/typegpu-docs/src/content/docs/tutorials/triangle-to-boids/code/step9-typegpu.ts | oxfmt reformat |
| apps/typegpu-docs/src/content/docs/tutorials/triangle-to-boids/code/step8-typegpu.ts | oxfmt reformat |
| apps/typegpu-docs/src/content/docs/tutorials/triangle-to-boids/code/step7-typegpu.ts | oxfmt reformat |
| apps/typegpu-docs/src/content/docs/tutorials/triangle-to-boids/code/step6-typegpu.ts | oxfmt reformat |
| apps/typegpu-docs/src/content/docs/tutorials/triangle-to-boids/code/step5-webgpu.ts | oxfmt reformat |
| apps/typegpu-docs/src/content/docs/tutorials/triangle-to-boids/code/step5-typegpu.ts | oxfmt reformat |
| apps/typegpu-docs/src/content/docs/tutorials/triangle-to-boids/code/step4-webgpu.ts | oxfmt reformat |
| apps/typegpu-docs/src/content/docs/tutorials/triangle-to-boids/code/step4-typegpu.ts | oxfmt reformat |
| apps/typegpu-docs/src/content/docs/tutorials/triangle-to-boids/code/step3-typegpu.ts | oxfmt reformat |
| apps/typegpu-docs/src/content/docs/tutorials/triangle-to-boids/code/step2-webgpu.ts | oxfmt reformat |
| apps/typegpu-docs/src/content/docs/tutorials/triangle-to-boids/code/step2-typegpu.ts | oxfmt reformat |
| apps/typegpu-docs/src/content/docs/tutorials/triangle-to-boids/code/step1side-typegpu.ts | oxfmt reformat |
| apps/typegpu-docs/src/components/translator/lib/wgslTool.ts | oxfmt reformat |
| apps/typegpu-docs/src/components/translator/lib/useAutoCompile.ts | oxfmt reformat |
| apps/typegpu-docs/src/components/translator/lib/translatorStore.ts | oxfmt reformat |
| apps/typegpu-docs/src/components/translator/lib/tgslExecutor.ts | oxfmt reformat |
| apps/typegpu-docs/src/components/translator/lib/rolldown.ts | oxfmt reformat |
| apps/typegpu-docs/src/components/translator/lib/editorConfig.ts | oxfmt reformat |
| apps/typegpu-docs/src/components/translator/lib/constants.ts | oxfmt reformat |
| apps/typegpu-docs/src/components/translator/TranslatorApp.tsx | oxfmt reformat (JSX) |
| apps/typegpu-docs/src/components/stackblitz/stackBlitzIndex.ts | oxfmt reformat |
| apps/typegpu-docs/src/components/design/VectorSlider.tsx | oxfmt reformat (JSX) |
| apps/typegpu-docs/src/components/design/Toggle.tsx | oxfmt reformat (JSX) |
| apps/typegpu-docs/src/components/design/TextArea.tsx | oxfmt reformat (JSX) |
| apps/typegpu-docs/src/components/design/Snackbar.tsx | oxfmt reformat (JSX) |
| apps/typegpu-docs/src/components/design/Slider.tsx | oxfmt reformat (JSX) |
| apps/typegpu-docs/src/components/design/Select.tsx | oxfmt reformat (JSX) |
| apps/typegpu-docs/src/components/design/DeleteIcon.tsx | oxfmt reformat (JSX) |
| apps/typegpu-docs/src/components/design/ColorPicker.tsx | oxfmt reformat (JSX) |
| apps/typegpu-docs/src/components/design/Button.tsx | oxfmt reformat (JSX) |
| apps/typegpu-docs/src/components/FpsCounter.tsx | oxfmt reformat (JSX) |
| apps/typegpu-docs/src/components/ExamplePage.tsx | oxfmt reformat (JSX) |
| apps/typegpu-docs/src/components/ExampleNotFound.tsx | oxfmt reformat (JSX) |
| apps/typegpu-docs/src/components/ExampleLink.tsx | oxfmt reformat (JSX) |
| apps/typegpu-docs/src/components/ExampleCard.tsx | oxfmt reformat (JSX) |
| apps/typegpu-docs/src/components/CodeEditor.tsx | oxfmt reformat (imports/JSX) |
| apps/typegpu-docs/scripts/transform-overloads.ts | oxfmt reformat |
| apps/typegpu-docs/package.json | dependency ordering/formatting update |
| apps/typegpu-docs/astro.config.mjs | oxfmt reformat |
| apps/treeshake-test/runTests.ts | oxfmt reformat |
| apps/treeshake-test/resultsTable.ts | oxfmt reformat |
| apps/treeshake-test/package.json | package.json formatting/ordering updates |
| apps/treeshake-test/generateTests.ts | oxfmt reformat |
| apps/treeshake-test/compareResults.ts | oxfmt reformat |
| apps/treeshake-test/bundleWith.ts | oxfmt reformat |
| apps/infra-benchmarks/src/discriminated-union.ts | oxfmt reformat |
| apps/infra-benchmarks/package.json | package.json formatting update |
| apps/bun-example/package.json | package.json dependency ordering update |
| .vscode/settings.json | removed Deno/run-on-save formatting config |
| .vscode/extensions.json | removed extension recommendations |
| .oxfmtrc.json | added oxfmt configuration |
| .github/workflows/pkg-pr.yml | removed Deno setup step |
| .github/workflows/ci.yml | removed Deno setup step |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -3,20 +3,5 @@ | |||
| "[astro]": { | |||
| "editor.defaultFormatter": "astro-build.astro-vscode" | |||
| }, | |||
There was a problem hiding this comment.
As part of the migration away from deno fmt, the workspace no longer pins a formatter for TypeScript/JavaScript (and removes the previous run-on-save formatting hook). If the repo expects contributors to use oxfmt, consider adding an explicit VS Code formatter configuration (or extension recommendation) for TS/JS so local formatting doesn’t drift and create noisy diffs.
| }, | |
| }, | |
| "[typescript]": { | |
| "editor.defaultFormatter": "oxc.oxc-vscode", | |
| "editor.formatOnSave": true | |
| }, | |
| "[javascript]": { | |
| "editor.defaultFormatter": "oxc.oxc-vscode", | |
| "editor.formatOnSave": true | |
| }, | |
| "[typescriptreact]": { | |
| "editor.defaultFormatter": "oxc.oxc-vscode", | |
| "editor.formatOnSave": true | |
| }, | |
| "[javascriptreact]": { | |
| "editor.defaultFormatter": "oxc.oxc-vscode", | |
| "editor.formatOnSave": true | |
| }, |
There was a problem hiding this comment.
I guess, but CI will fail anyway and there is always nr fix
0a92414 to
fd2cf7c
Compare
aleksanderkatan
left a comment
There was a problem hiding this comment.
Ofc, I didn't see every change, but I checked all folders for files worth checking, and I scanned files with huge +/- discrepancies, and everything looks great!
Let's go!
| @@ -3,20 +3,5 @@ | |||
| "[astro]": { | |||
| "editor.defaultFormatter": "astro-build.astro-vscode" | |||
| }, | |||
There was a problem hiding this comment.
I guess, but CI will fail anyway and there is always nr fix
| <div | ||
| className='absolute right-8 bottom-8 z-40 box-border flex max-w-[min(28rem,calc(100vw-4rem))] items-center gap-4 rounded-lg bg-red-100 p-4 text-gray-500' | ||
| role='alert' | ||
| className="absolute right-8 bottom-8 z-40 box-border flex max-w-[min(28rem,calc(100vw-4rem))] items-center gap-4 rounded-lg bg-red-100 p-4 text-gray-500" |
There was a problem hiding this comment.
Some places (components?) now use " instead of ', do we care?
There was a problem hiding this comment.
It's completely fine
| @@ -0,0 +1,5 @@ | |||
| { | |||
| "$schema": "./node_modules/oxfmt/configuration_schema.json", | |||
| "ignorePatterns": ["**/*.mdx", "**/*.md"], | |||
There was a problem hiding this comment.
Some markdowns (like packages/typegpu-concurrent-scan/README.md) were updated despite of this, though only the ts blocks were affected, so I guess this is fine, but still not what I would expect
Now that I look at it, docs were not updated, can we try and apply oxfmt to them as well? (maybe in another PR)
There was a problem hiding this comment.
There seems to be bugs in oxfmt when formatting .mdx files. Perhaps we can reproduce them and report them, but for now, I opted to disable them.
| @@ -0,0 +1,5 @@ | |||
| { | |||
| "$schema": "./node_modules/oxfmt/configuration_schema.json", | |||
| "ignorePatterns": ["**/*.mdx", "**/*.md"], | |||
There was a problem hiding this comment.
Is there an option to enable this in jsdoc as well?
36b88a6 to
ca892ad
Compare
Change fix command
ca892ad to
47b71b2
Compare
No description provided.