fix: range creates array with only one element when end is 0 #463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
- because 0 is falsy the start was overwritten with 0 when end is 0 resulting in the array [0] - explicitly check for end !== undefined to prevent this - add test case where end is 0
Richard-Krug
force-pushed
the
fix-range-for-end-zero
branch
from
20d6dfc to
fdb733b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
rangecreates an array with only one element whenendis0range(-3, 0)returned[0]instead of[-3, -2, -1, 0]0is falsy the start was overwritten with0when end is0resulting in the array[0]end !== undefinedto prevent thisendis0Checklist
package.jsonhas been bumped (matching semver)yarn buildcommand has been run and to update thecdndirectory/docsdirectory) has been updated