fix(sharded): SSUBSCRIBE smessageBuffer memory leak (#528) #529
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposed fix for #528.
This pull request introduces a change to the sharded adapter's
SSUBSCRIBE
logic: Previously, for each dynamic channel/room, a unique listener was added to the client'ssmessageBuffer
. This approach led to a large number of listeners (resulting inMaxListenersExceededWarning
), especially in scenarios with many dynamic channels. Further, listeners were not being removed when unsubscribing, leading to a memory leak.The new implementation replaces the multiple listeners with a single
smessageBuffer
listener. This listener is registered once and handles all dynamic channels by maintaining specific channel handlers in aMap
. Listeners are added to thisMap
inSSUBSCRIBE
and removed from theMap
inSUNSUBSCRIBE
.Thanks for your review! 🙏