fix: waitFor message latency causing missed packets
#33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! Thanks for the pull request 👍 I think it could also be fixed with a buffer, something like this: 49fe300 What do you think? |
|
Your solution also work, it has the advantage that it is also working on the browser whereas mine only works for node.js (because it uses the official stream implementation). This issue also need to be fixed on the engine.io test-suite (I already prepared all the patches with my solution). But if you prefer to do your's, no problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix issue #32. The proposed solution is to extend the
wsWebSocket instance to add an async iterator working with the utility functioncreateWebSocketStreamcoming from thewslibrary.It has a minimal impact on the test suite codebase.