In TLS build of library, support both TLS and non-TLS connections. #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The choice is made at runtime, if a TLS URI (https:// or wss://) is given, the TLS client will be used, otherwise the non-TLS client will be used. Additionally, a new constructor is introduced allowing the URI to be passed at construction, which allows the above selection to occur, otherwise only the default for the library (TLS or non-TLS) will be used (preserving the original behavior).
joelnordell
force-pushed
the
eris-sio_tls_support_non_tls_uris
branch
from
c00e9e3 to
20ce61d
Compare
|
NOTE: this will have a small merge conflict with #136. |
mtdxc
approved these changes
Oct 16, 2018
mtdxc
pushed a commit
to mtdxc/socket.io-client-cpp
that referenced
this pull request
Oct 16, 2018
…-TLS connections. The choice is made at runtime, if a TLS URI (https:// or wss://) is given, the TLS client will be used, otherwise the non-TLS client will be used. Additionally, a new constructor is introduced allowing the URI to be passed at construction, which allows the above selection to occur, otherwise only the default for the library (TLS or non-TLS) will be used (preserving the original behavior).
|
Hi, When will this be merged? |
mtdxc
pushed a commit
to mtdxc/socket.io-client-cpp
that referenced
this pull request
Jul 29, 2021
…-TLS connections. The choice is made at runtime, if a TLS URI (https:// or wss://) is given, the TLS client will be used, otherwise the non-TLS client will be used. Additionally, a new constructor is introduced allowing the URI to be passed at construction, which allows the above selection to occur, otherwise only the default for the library (TLS or non-TLS) will be used (preserving the original behavior).
mtdxc
pushed a commit
to mtdxc/socket.io-client-cpp
that referenced
this pull request
Jul 29, 2021
…-TLS connections. The choice is made at runtime, if a TLS URI (https:// or wss://) is given, the TLS client will be used, otherwise the non-TLS client will be used. Additionally, a new constructor is introduced allowing the URI to be passed at construction, which allows the above selection to occur, otherwise only the default for the library (TLS or non-TLS) will be used (preserving the original behavior).
|
Is there any progress/update here? |
|
Hi! I'll take a look. I think the main developer is not around any more and I'm mostly in charge of maintaining the CMake but let's see what I can do. |
|
Okay @joelnordell I opened a PR to update it to the state of master ErisExchange#5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The choice is made at runtime, if a TLS URI (
https://orwss://) is given, the TLS client will be used, otherwise the non-TLS client will be used.Additionally, a new constructor is introduced allowing the URI to be passed at construction, which allows the above selection to occur, otherwise only the default for the library (TLS or non-TLS) will be used (preserving the original behavior).
This allows
libsioclient_tls.ato support both TLS and non-TLS connections, chosen at runtime, without recompiling.With this change, you can now do the following: