Upgrade to OkHttp 4.10.0, fixes #112 #113
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OkHttp 3.13.x+ targets Java 8 byte code... |
|
@asghol thanks for the PR 👍 I think we will indeed need to drop support for Java 7 and create a new major version. Let me triage a few more issues in the Java client and we will proceed 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OkHttp 3 and 4 are supposed to be fairly compatible according to OkHttp themselves. I do see some SocketException entries when running the tests. The test go green however and I've intercepted some of the tests to make sure that the test is not flakey with good results.
I'm still new to this project though so be critical.
References:
https://square.github.io/okhttp/changelogs/upgrading_to_okhttp_4/