Update to Conductor V3 #44
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes will review it over the weekend
andreasvettefors <[email protected]> schrieb am Di., 23. Juni 2020,
13:56:
… @sockeqwe <https://github.com/sockeqwe> Any plans to merge this or else
we can't upgrade the newest Conductor.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#44 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEOPLUCZBCIHOL3ZAZP5VDRYCJ6RANCNFSM4NSRD6FQ>
.
|
|
@sockeqwe Do you have any update? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Changed MVP,ViewState and MVI to accept Conductor version3 and Mosby3.1.1
-Update sample app MVI and renewed to Kotlin
-Update sample app
-Update to AndroidX
-Delete Findbugs Gradle. It seems findbugs plugin is not supporting jdk11
-CleanUp gradle files with library latest version
It's my first pull request so any feedback is welcome on what I did or not did well.