fix: add a routable string helper to verevet.Version #401
Conversation
- helps with templating version string
tinygrasshopper
force-pushed
the
fix/add-routable-string-to-version
branch
from
b86b56b to
51876ff
Compare
| return v.String() | ||
| } | ||
| return v.DateString() | ||
| } |
There was a problem hiding this comment.
Should this replace String? What use cases are there for using the original String method over this one?
There was a problem hiding this comment.
The blast radius for that change would be quite a lot, the .String method is used in other contexts. We can replace the .String -> .RoutableString iteratively where needed
There was a problem hiding this comment.
That's what semantic versioning is for
There was a problem hiding this comment.
That's what semantic versioning is for
Dont get what you mean by that bit
Currently, there are 58 usages for version.String() in the vervet codebase and the RoutableString implementation is not valid for all of them. We might introduce a lot of unintended side-effects if we replace the String method
ifin the templating