fix: update vervet dependencies #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps Go dependencies to their latest minor versions. getkin/kin-openapi is in v0 and introduced breaking changes in v0.113.0 that this changeset deals with: https://github.com/getkin/kin-openapi#v01130 OpenAPI Extensions are now of type map[string]interface{} instead of a map embedded in a struct. This impacts the way Reflect Walk has to be performed. A few openapi3 types have now an `extra` unexported field which needs to be ignored when comparing struct with go-cmp. A mergeMap generic utility function has been introduced to simplify merging components and avoid code repetition.
Closed
Todai88
approved these changes
Feb 6, 2023
jlourenc
added a commit
that referenced
this pull request
Feb 7, 2023
PR #269 introduces a bug with the upgrade of kin-openapi. Component extensions are not correctly identified and considered as part of merging specs. However, a nil pointer exception can occur when no extensions are specified as part of a spec. This PR correctly handles this nil pointer and add tests to validate behaviour.
jlourenc
added a commit
that referenced
this pull request
Feb 7, 2023
PR #269 introduces a bug with the upgrade of kin-openapi. Component extensions are not correctly identified and considered as part of merging specs. However, a nil pointer exception can occur when no extensions are specified as part of a spec. This PR correctly handles this nil pointer and add tests to validate behaviour.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps Go dependencies to their latest minor versions.
getkin/kin-openapi is in v0 and introduced breaking changes in v0.113.0 that this changeset deals with: https://github.com/getkin/kin-openapi#v01130
OpenAPI Extensions are now of type map[string]interface{} instead of a map embedded in a struct. This impacts the way Reflect Walk has to be performed.
A few openapi3 types have now an
extraunexported field which needs to be ignored when comparing struct with go-cmp.A mergeMap generic utility function has been introduced to simplify merging components and avoid code repetition.
Fixes #268
Supersedes #259