feat: add plugin installed event [IDE-736] #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastiandoetsch
changed the title
acke
approved these changes
Nov 4, 2024
| @@ -26,7 +26,10 @@ import java.util.UUID | |||
| storages = [Storage("snyk.settings.xml", roamingType = RoamingType.DISABLED)], | |||
| ) | |||
| class SnykApplicationSettingsStateService : PersistentStateComponent<SnykApplicationSettingsStateService> { | |||
| val requiredLsProtocolVersion = 16 | |||
| // events | |||
| var pluginInstalledSent: Boolean = false | |||
There was a problem hiding this comment.
Will plugin developers working towards prod send a plugin installed event every time we start debug sessions? Will this be an issue for reporting?
There was a problem hiding this comment.
Should not be an issue, as these versions would have a snapshot version of the integrationName. Any report would of cause need to filter snapshot or dev versions.
There was a problem hiding this comment.
The issue would only occur in our org anyways.
ShawkyZ
approved these changes
Nov 4, 2024
bastiandoetsch
force-pushed
the
feat/IDE-736_send-analytics
branch
from
6dfb39a to
40b9c02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds code to send analytics to track plugin installation. It could later be extended to send more events.
Depends on CLI preview release with protocol version 17
Checklist
Screenshots / GIFs
Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!