Skip to content

Commit

Permalink
chore: add changelog, minor visibility change to private methods
Browse files Browse the repository at this point in the history
  • Loading branch information
bastiandoetsch committed Nov 4, 2024
1 parent 4127072 commit 9756541
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
## [2.11.0]
### Changed
- If $/snyk.hasAuthenticated transmits an API URL, this is saved in the settings.
- Add "plugin installed" analytics event (sent after authentication)

## [2.10.0]
### Changed
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -129,13 +129,13 @@ class SnykCliDownloaderService {
return pluginSettings().currentLSProtocolVersion == pluginSettings().requiredLsProtocolVersion
}

fun isFourDaysPassedSinceLastCheck(): Boolean {
private fun isFourDaysPassedSinceLastCheck(): Boolean {
val previousDate = pluginSettings().getLastCheckDate() ?: return true

return ChronoUnit.DAYS.between(previousDate, LocalDate.now()) >= NUMBER_OF_DAYS_BETWEEN_RELEASE_CHECK
}

fun isNewVersionAvailable(currentCliVersion: String?, newCliVersion: String?): Boolean {
private fun isNewVersionAvailable(currentCliVersion: String?, newCliVersion: String?): Boolean {
val cliVersionsNullOrEmpty =
currentCliVersion == null || newCliVersion == null ||
currentCliVersion.isEmpty() || newCliVersion.isEmpty()
Expand Down

0 comments on commit 9756541

Please sign in to comment.