chore: stop v1 analytics - cli-569 #5568
Draft
+1
−784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sandor-trombitas
force-pushed
the
CLI-569-stop-v1-analytics
branch
from
6f0cb5a
to
21a9ecf
Compare
sandor-trombitas
changed the title
sandor-trombitas
force-pushed
the
CLI-569-stop-v1-analytics
branch
2 times, most recently
from
97fb41e
to
4ed271b
Compare
sandor-trombitas
force-pushed
the
CLI-569-stop-v1-analytics
branch
from
4ed271b
to
34556b8
Compare
sandor-trombitas
changed the title
sandor-trombitas
force-pushed
the
CLI-569-stop-v1-analytics
branch
3 times, most recently
from
5206019
to
da38e11
Compare
sandor-trombitas
force-pushed
the
CLI-569-stop-v1-analytics
branch
from
da38e11
to
95ab4fa
Compare
PeterSchafer
reviewed
Nov 7, 2024
src/lib/analytics/index.ts
Outdated
| } else { | ||
| return true; | ||
| } | ||
| // Analytics disabled until we can migrate to v2 analytics |
There was a problem hiding this comment.
nitpick: I'm not sure this comment makes sense :) maybe just remove it
PeterSchafer
reviewed
Nov 7, 2024
PeterSchafer
reviewed
Nov 7, 2024
sandor-trombitas
force-pushed
the
CLI-569-stop-v1-analytics
branch
from
600d762
to
5aa03ce
Compare
PeterSchafer
reviewed
Nov 8, 2024
| ); | ||
| expect(stdout).toContain(project.path('package.json')); | ||
|
|
||
| const requests = server.getRequests().filter((req: any) => { |
There was a problem hiding this comment.
Suggestion: for this test, it might be worth to just remove the part that uses the analytics data to assert and leave the rest.
sandor-trombitas
force-pushed
the
CLI-569-stop-v1-analytics
branch
from
5aa03ce
to
067c782
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Submission Checklist
What does this PR do?
Stop sending v1 analytics
Where should the reviewer start?
Review code changes
How should this be manually tested?
Run a command in debug mode and look for
analytics disabled