rss.from_as1: remove possible addition of invalid author element

snarfed · Dec 18, 2024 · a841d77 · a841d77
1 parent 14c9653
commit a841d77
Showing 1 changed file with 5 additions and 7 deletions.
diff --git a/granary/rss.py b/granary/rss.py
@@ -120,13 +120,11 @@ def from_as1(activities, actor=None, title=None, feed_url=None,
     item.category(categories)
 
     author = as1.get_object(obj, 'author')
-    author = {
-      'name': (author.get('displayName') or author.get('username')
-               or author.get('url') or author.get('id')),
-      'uri': author.get('url') or author.get('id'),
-      'email': author.get('email') or '-',
-    }
-    item.author(author)
+    if 'email' in author:
+      # author is optional in RSS 2.0 item spec,
+      # but if present, must be the email address of the author
+      # ref: https://www.rssboard.org/rss-specification#ltauthorgtSubelementOfLtitemgt
+      item.author(author={'email': author.get('email')})
 
     published = obj.get('published') or obj.get('updated')
     if published and isinstance(published, str):