chore: prefer usize::MAX to std::usize::MAX #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tison <[email protected]>
notgull
reviewed
Oct 6, 2023
src/lib.rs
Outdated
Comment on lines
138
to
139
| unsafe impl Send for Event {} | ||
| unsafe impl Sync for Event {} |
There was a problem hiding this comment.
I don't like the additional unsafe here. Can we just add a test to make sure the Event struct is Send and Sync?
There was a problem hiding this comment.
add a test
Do you mean that we ensure the auto trait happens by testing? What's the difference to this patch that let the compiler do the "test"?
These two lines are automatically done if it meets the auto trait conditions. We declare them explicitly for testing here.
There was a problem hiding this comment.
There was a problem hiding this comment.
OK. I'm pushing a commit now - this seems a style preference :D
There was a problem hiding this comment.
We already have it in _assert_send_and_sync.
Then I'll convert this patch as a trivial code tidy one.
Signed-off-by: tison <[email protected]>
tisonkun
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #140 (comment)
Hopefully, we can move
Events free. Open for comments :D