Extend needless_lifetimes
to suggest eliding impl
lifetimes
#2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example:
The main change is in how
impl
lifetime uses are tracked. Previously, a hashmap was created, and lifetimes were removed from the hashmap as their uses were discovered. However, the uses are needed to generate elision suggestions. So, now, uses are added to the hashmap as they are discovered.The PR is currently organized as six commits, which I think are self-explanatory:
needless_lifetimes
to suggest elidingimpl
lifetimesclippy_lints
andclippy_utils
needless_lifetimes
testr? @Alexendoo (I think you are
needless_lifetimes
' primary author? Sorry if I have this wrong.)changelog: Extend
needless_lifetimes
to suggest elidingimpl
lifetimes