Add breakingChanges for httpChecksum trait #2398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yefrig
approved these changes
Sep 17, 2024
| breakingChanges: [ | ||
| { | ||
| change: "remove", | ||
| severity: "ERROR", |
There was a problem hiding this comment.
Should we include a message when the entire trait is removed?
There was a problem hiding this comment.
oh I wanted to add message later after adding test, but forgot. thanks for catching.
hpmellema
reviewed
Sep 17, 2024
| breakingChanges: [ | ||
| { | ||
| change: "remove", | ||
| severity: "ERROR", |
There was a problem hiding this comment.
Error is the default severity for breaking changes, so we can probably remove that here.
There was a problem hiding this comment.
I noticed that the request compression rules use DANGER see. These seem like they would have the same severity.
There was a problem hiding this comment.
I debated it and felt removal of compression being less severe than removal of checksums was reasonable. But don't feel strongly about it, so changing to DANGER.
| path: "/requestValidationModeMember", | ||
| severity: "ERROR", | ||
| message: """ | ||
| `requestValidationModeMember` was removed so newly generated clients will no longer validate response \ |
There was a problem hiding this comment.
Suggested change
| `requestValidationModeMember` was removed so newly generated clients will no longer validate response \ | |
| `requestValidationModeMember` was removed, so newly generated clients will no longer validate response \ |
gosar
force-pushed
the
httpChecksum-breakingChanges
branch
from
e1bf982
to
e4001f9
Compare
hpmellema
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
The
aws.protocols#httpChecksumtrait was missing any rules for detecting backwards incompatible changes to the applied trait. This PR addsbreakingChangesto the trait definition.Testing
Added tests to assert the events for diff.
Links
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.