fix: Retry handling for streamed request bodies #852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbelkins
commented
Nov 8, 2024
| @@ -167,20 +168,22 @@ class OrchestratorTests: XCTestCase { | |||
| } | |||
|
|
|||
| class TraceExecuteRequest: ExecuteRequest { | |||
There was a problem hiding this comment.
The behavior of this type is unchanged; I added a variable to allow for counting of retry attempts that is separate from the original allowed count.
jbelkins
commented
Nov 8, 2024
| @@ -1315,4 +1318,43 @@ class OrchestratorTests: XCTestCase { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
The RetryBackoffStrategy below always sets a retry delay of 0 so the retry tests can proceed without waiting for any retry delay. This prevents the first test below from taking 0.5-2 seconds to finish.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This change ensures that retry is only used when a request body is reusable, and that the request body is prepared for reuse if needed.
Additionally, unit tests are added to
Orchestratorto verify correct retry behavior.Scope
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.