Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

db.py: Refactor type annotations #1787

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RA80533
Copy link
Contributor

@RA80533 RA80533 commented Jun 5, 2023

  • scanResultEvent()'s arguments were not documented correctly. Many of them could be list in addition to str.
  • Note that scanResultEvent() is not called correctly in several places (filterFp is often passed as the third arg).
  • scanConfigSet()'s scan_id was incorrectly documented as being an int (it's actually a str). It doesn't appear that this distinction matters to any of the places the function was called.

@codecov-commenter
Copy link

Codecov Report

Merging #1787 (3742694) into master (d8f628b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##           master    #1787   +/-   ##
=======================================
  Coverage   46.74%   46.75%           
=======================================
  Files         690      690           
  Lines       45701    45706    +5     
=======================================
+ Hits        21365    21370    +5     
  Misses      24336    24336           
Impacted Files Coverage Δ
spiderfoot/db.py 71.26% <100.00%> (+0.20%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@RA80533 RA80533 force-pushed the refactor/typing/spiderfoot--db branch from 3742694 to 3bf759a Compare June 6, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants