Sync to latest version & improvements #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am not the maintainer of the project. I do not think however the make file that is meant to build the image should also manage the run-time aspects of the container including managing the network. |
|
I agree with @christf . |
|
well, besides the network config there were other changes in this PR that look useful. Maybe re-raising those separately would be helpful? |
smhaller
added a commit
that referenced
this pull request
Jan 17, 2022
|
There were not many modifications. We should not put sharelatex:latest because on version switches one sometimes has to adapt the authentication file - and the main branch should be a working one (see Issue #7). The automated network creation we keep outside the Makefile. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tlmgrworks, validated by myself