Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating Mphys wrapper for 2.0 update #315

Merged
merged 9 commits into from
Dec 12, 2024
Merged

Updating Mphys wrapper for 2.0 update #315

merged 9 commits into from
Dec 12, 2024

Conversation

timryanb
Copy link
Collaborator

@timryanb timryanb commented May 17, 2024 •
edited
Loading

  • Refactored builder class to use new mphys import procedures and variable naming convention
  • Changing how coupled tacs problems are setup in builder. No longer using a coupled boolean flag, instead user passes forces to be added to RHS as list of str
  • MPhys examples and tests in tacs repo are updated and working (using this PR of MPhys)
  • CI expected to fail until MPhys 2.0 is released
  • To be merged in when after MPhys release

@timryanb timryanb requested a review from A-CGray May 17, 2024 13:13
@timryanb
Merge branch 'master' into mphys-2.0
1a448cd 
# Conflicts:
#	tests/integration_tests/test_mphys_struct_buckling.py
@timryanb
Updating broken test
d8fa828
@timryanb timryanb mentioned this pull request Dec 9, 2024
Merged
A-CGray
A-CGray reviewed Dec 11, 2024
View reviewed changes
setup.py Outdated Show resolved Hide resolved
A-CGray
A-CGray approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@A-CGray A-CGray left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've run the integration tests locally with mphys 2.0 and all are fine, so once mphys-2.0.0 is released on pypi and the CI jobs pass I'm happy to merge

@A-CGray A-CGray marked this pull request as ready for review December 11, 2024 19:51
@A-CGray A-CGray merged commit e5e4d26 into smdogroup:master Dec 12, 2024
5 checks passed
@timryanb timryanb deleted the mphys-2.0 branch December 12, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@A-CGray A-CGray A-CGray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timryanb @A-CGray