-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nested blocks parsing #10
Open
glensc
wants to merge
2
commits into
master
Choose a base branch
from
translation_in_argument
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seems smarty relies here on implementation details. i.e fills php variable in place of {function name="reply_button" class="" title="" data=""}{/function}
{reply_button title="{t}reply as email{/t}" class="reply_as_email"} parsed into tokens:
|
glensc
force-pushed
the
translation_in_argument
branch
3 times, most recently
from
November 12, 2017 03:29
395b271
to
1363e4b
Compare
that above template cache: <?php ob_start();
$_smarty_tpl->smarty->_cache['_tag_stack'][] = array('t', array());
$_block_repeat=true;
echo smarty_block_t(array(), null, $_smarty_tpl, $_block_repeat);
while ($_block_repeat) {
ob_start();
echo "reply as email";
$_block_repeat=false;
echo smarty_block_t(array(), ob_get_clean(), $_smarty_tpl, $_block_repeat);
}
array_pop($_smarty_tpl->smarty->_cache['_tag_stack']);
$_prefixVariable1=ob_get_clean();
$_smarty_tpl->smarty->ext->_tplFunction->callTemplateFunction($_smarty_tpl, 'reply_button', array('title'=>$_prefixVariable1,'c....
|
glensc
force-pushed
the
translation_in_argument
branch
from
November 12, 2017 12:10
1363e4b
to
90aaed8
Compare
smarty parses it, tsmarty2c does not
glensc
force-pushed
the
translation_in_argument
branch
from
November 12, 2017 12:34
90aaed8
to
9c5fc60
Compare
this problem seems unsolveable unless someone implements Smarty parser themselves. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
smarty parses it, tsmarty2c does not: