Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/DF-20612 por address list solv #3582

Merged
merged 4 commits into from
Nov 24, 2024
Merged

Conversation

mmcallister-cll
Copy link
Contributor

@mmcallister-cll mmcallister-cll commented Nov 23, 2024

Relates to #DF-20612

Description

Fixing multichain address list endpoint for solv by adding separate ABI and abiName endpoint input param selector

Steps to Test

  1. yarn test por-address-list
  2. regression test other x-chain PoR requests still work after adding new required input param
  3. test with solv payload

Quality Assurance

  • If a new adapter was made, or an existing one was modified so that its environment variables have changed, update the relevant infra-k8s configuration file.
  • If a new adapter was made, or an existing one was modified so that its environment variables have changed, update the relevant adapter-secrets configuration file or update the soak testing blacklist.
  • If a new adapter was made, or a new endpoint was added, update the test-payload.json file with relevant requests.
  • The branch naming follows git flow (feature/x, chore/x, release/x, hotfix/x, fix/x) or is created from Jira.
  • This is related to a maximum of one Jira story or GitHub issue.
  • Types are safe (avoid TypeScript/TSLint features like any and disable, instead use more specific types).
  • All code changes have 100% unit and integration test coverage. If testing is not applicable or too difficult to justify doing, the reasoning should be documented explicitly in the PR.

@mmcallister-cll mmcallister-cll requested a review from a team November 23, 2024 16:52
Copy link

changeset-bot bot commented Nov 23, 2024

🦋 Changeset detected

Latest commit: 278c8cd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@chainlink/por-address-list-adapter Minor
@chainlink/proof-of-reserves-adapter Patch
@chainlink/renvm-address-set-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mxiao-cll
Copy link
Contributor

Also need to update soak test payload

@mxiao-cll mxiao-cll merged commit e5a1b76 into main Nov 24, 2024
8 checks passed
@mxiao-cll mxiao-cll deleted the fix/DF-20612-por-address-list-solv branch November 24, 2024 14:20
@github-actions github-actions bot mentioned this pull request Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants