Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update includes.json #3473

Merged
merged 2 commits into from
Oct 11, 2024
Merged

Update includes.json #3473

merged 2 commits into from
Oct 11, 2024

Conversation

nikhsha
Copy link
Collaborator

@nikhsha nikhsha commented Oct 11, 2024

Closes #ISSUE_NUMBER_GOES_HERE

Description

Adding inverse logic for Tradingeconomics

Changes

  • High level
  • changes that
  • you made

Steps to Test

  1. Steps
  2. to
  3. test

Quality Assurance

  • If a new adapter was made, or an existing one was modified so that its environment variables have changed, update the relevant infra-k8s configuration file.
  • If a new adapter was made, or an existing one was modified so that its environment variables have changed, update the relevant adapter-secrets configuration file or update the soak testing blacklist.
  • If a new adapter was made, or a new endpoint was added, update the test-payload.json file with relevant requests.
  • The branch naming follows git flow (feature/x, chore/x, release/x, hotfix/x, fix/x) or is created from Jira.
  • This is related to a maximum of one Jira story or GitHub issue.
  • Types are safe (avoid TypeScript/TSLint features like any and disable, instead use more specific types).
  • All code changes have 100% unit and integration test coverage. If testing is not applicable or too difficult to justify doing, the reasoning should be documented explicitly in the PR.

@nikhsha nikhsha requested review from austinborn and a team October 11, 2024 15:55
Copy link

changeset-bot bot commented Oct 11, 2024

🦋 Changeset detected

Latest commit: 1fec1d4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@chainlink/tradingeconomics-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

@FionnL FionnL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add EUR too?

austinborn
austinborn previously approved these changes Oct 11, 2024
@austinborn austinborn merged commit bd95e2e into main Oct 11, 2024
8 checks passed
@austinborn austinborn deleted the add-inverse-for-tradingeconomics-czk branch October 11, 2024 19:03
@github-actions github-actions bot mentioned this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants