-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/df 18875 cryptocompare inverse eth usd #3049
Feature/df 18875 cryptocompare inverse eth usd #3049
Conversation
🦋 Changeset detectedLatest commit: 091975d The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
The soak test failures seem to only happen a fraction of the time, and most likely not caused by these changes
|
|
|
Closes #DF_18875
Description
Add inverse behaviour to Cryptocompare to support BTC-ETH pair. Since cryptocompare only supports ETH-BTC pair.
Changes
add Request Transformation for
Steps to Test
yarn test packages/source/cryptocompare
Quality Assurance
infra-k8s
configuration file.adapter-secrets
configuration file or update the soak testing blacklist.test-payload.json
file with relevant requests.feature/x
,chore/x
,release/x
,hotfix/x
,fix/x
) or is created from Jira.