InMemory store should only return deep copies.#17061
Merged
Conversation
…ion is effectively immutable
ettec
changed the title
cedric-cordenier
previously approved these changes
Apr 1, 2025
cedric-cordenier
approved these changes
Apr 1, 2025
|
chudilka1
approved these changes
Apr 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jordans race condition tests identified a flaw in the inmemory store when compared with the DB store, in essence the DB store was deep copying the executions before returning them to the caller which prevented race condition, this PR updates the in memory store to do the same ensuring the returned objects are effectively immutable.
As an unrelated TODO we should probably modify the workflow execution type to make it clear that it is effectively immutable to prevent any unexpected side effects from new code attempting to modify the state of a workflowexecution object outside of the store - captured here-> https://smartcontract-it.atlassian.net/browse/CAPPL-682