-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: increase timeouts in workflow_syncer_test #15818
Open
erikburt
wants to merge
3
commits into
develop
Choose a base branch
from
chore/increase-timeout-workflow-syncer-test
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+7
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chainchad
previously approved these changes
Dec 30, 2024
jmank88
reviewed
Jan 2, 2025
core/services/relay/evm/capabilities/workflows/syncer/workflow_syncer_test.go
Outdated
Show resolved
Hide resolved
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
jmank88
approved these changes
Jan 2, 2025
george-dorin
approved these changes
Jan 3, 2025
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
tests.WaitTimeout
rather than hardcoded timeout for allrequire.Eventually
inworkflow_syncer_test
Motivation
#15537 caused a consistent failure for the "Experimental Test Optimization" workflow. I believe this is due to the increased concurrency while running causing performance issues.
RE-3313