[CAPPL-320] hex decode workflowName when logged via beholder #15815
+41
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agparadiso
changed the title
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
agparadiso
force-pushed
the
CAPPL-320_decode_workflow_name
branch
from
eb46205 to
1f831d9
Compare
|
ettec
reviewed
Jan 2, 2025
| @@ -298,9 +299,19 @@ func (c *Compute) createFetcher() func(ctx context.Context, req *wasmpb.FetchReq | |||
| return nil, fmt.Errorf("workflow execution ID %q is invalid: %w", req.Metadata.WorkflowExecutionId, err) | |||
| } | |||
|
|
|||
| // best effort to decode the workflow name | |||
There was a problem hiding this comment.
is there a reason why this repeated code is not put in a single place? no obvious place for it to go?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr introduces a fix to hex decode the workflow name whenever we log it via beholder
CAPPL-320
Requires
Supports