Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add parent block hash #15802

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

dhaidashenko
Copy link
Collaborator

Requires

Supports

Copy link
Contributor

github-actions bot commented Dec 23, 2024

AER Report: CI Core

aer_workflow , commit , Detect Changes , Scheduled Run Frequency , Clean Go Tidy & Generate , Flakeguard Root Project / Get Tests To Run , Core Tests (go_core_tests) , GolangCI Lint (.) , Core Tests (go_core_tests_integration) , GolangCI Lint (integration-tests) , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_fuzz) , Core Tests (go_core_race_tests) , test-scripts , Flakeguard Deployment Project , Flakeguard Root Project / Run Tests , Flakeguard Root Project / Report , lint , SonarQube Scan , Flakey Test Detection

1. Syntax error in composite literal: [Golang Lint (integration-tests)]

Source of Error:
##[error]contracts/ccipreader_test.go:1026:54: syntax error: unexpected ) in composite literal; possibly missing comma or }
##[error]contracts/ccipreader_test.go:1027:3: syntax error: unexpected }, expected expression
##[error]contracts/ccipreader_test.go:1154:53: syntax error: unexpected ) in composite literal; possibly missing comma or }
##[error]contracts/ccipreader_test.go:1155:3: syntax error: unexpected }, expected expression
##[error]contracts/ccipreader_test.go:1316:53: syntax error: unexpected ) in composite literal; possibly missing comma or }
##[error]contracts/ccipreader_test.go:1317:3: syntax error: unexpected }, expected expression (typecheck)
**Why**: The errors indicate that there are missing commas or closing braces in composite literals in the `ccipreader_test.go` file, causing syntax errors.

Suggested fix: Review the composite literals in the specified lines and ensure that all elements are properly separated by commas and that all braces are correctly closed.

2. Missing ',' in composite literal: [Golang Lint (integration-tests)]

Source of Error:
##[error]integration-tests/contracts/ccipreader_test.go:1026:54: missing ',' in composite literal (typecheck)
##[error]integration-tests/contracts/ccipreader_test.go:1050:2: missing ',' in composite literal (typecheck)
##[error]integration-tests/contracts/ccipreader_test.go:1064:2: missing ',' in composite literal (typecheck)
##[error]integration-tests/contracts/ccipreader_test.go:1065:93: missing ',' before newline in composite literal (typecheck)
##[error]integration-tests/contracts/ccipreader_test.go:1066:3: missing ',' before newline in composite literal (typecheck)
##[error]integration-tests/contracts/ccipreader_test.go:1069:16: missing ',' before newline in composite literal (typecheck)
##[error]integration-tests/contracts/ccipreader_test.go:1071:2: expected operand, found 'for' (typecheck)
**Why**: These errors are due to missing commas in composite literals, which are required to separate elements within the literals.

Suggested fix: Add the missing commas in the composite literals at the specified lines to ensure proper syntax.

3. Require error assertion: [Golang Lint (.)]

Source of Error:
##[error]core/services/ocr2/plugins/ccip/internal/ccipdata/offramp_reader_test.go:130:2: require-error: for error assertions use require (testifylint)
**Why**: The error indicates that the `require` package should be used for error assertions instead of `assert` in the specified test file.

Suggested fix: Replace assert.NoError with require.NoError in the specified line to comply with the testifylint linter's requirements.

4. Column does not exist: [Core Tests (go_core_tests)]

Source of Error:
##[error]Error: error mapping test results to paths: error parsing file /home/runner/work/chainlink/chainlink/integration-tests/contracts/ccipreader_test.go: /home/runner/work/chainlink/chainlink/integration-tests/contracts/ccipreader_test.go:1026:54: missing ',' in composite literal (and 123 more errors)
##[error]Error: error mapping test results to paths: error parsing file /home/runner/work/chainlink/chainlink/integration-tests/contracts/ccipreader_test.go: /home/runner/work/chainlink/chainlink/integration-tests/contracts/ccipreader_test.go:1026:54: missing ',' in composite literal (and 123 more errors)
##[error]Error: error mapping test results to paths: error parsing file /home/runner/work/chainlink/chainlink/integration-tests/contracts/ccipreader_test.go: /home/runner/work/chainlink/chainlink/integration-tests/contracts/ccipreader_test.go:1026:54: missing ',' in composite literal (and 123 more errors)
##[error]Error: error mapping test results to paths: error parsing file /home/runner/work/chainlink/chainlink/integration-tests/contracts/ccipreader_test.go: /home/runner/work/chainlink/chainlink/integration-tests/contracts/ccipreader_test.go:1026:54: missing ',' in composite literal (and 123 more errors)
##[error]Error: error mapping test results to paths: error parsing file /home/runner/work/chainlink/chainlink/integration-tests/contracts/ccipreader_test.go: /home/runner/work/chainlink/chainlink/integration-tests/contracts/ccipreader_test.go:1026:54: missing ',' in composite literal (and 123 more errors)
##[error]Error: error mapping test results to paths: error parsing file /home/runner/work/chainlink/chainlink/integration-tests/contracts/ccipreader_test.go: /home/runner/work/chainlink/chainlink/integration-tests/contracts/ccipreader_test.go:1026:54: missing ',' in composite literal (and 123 more errors)
##[error]Error: error mapping test results to paths: error parsing file /home/runner/work/chainlink/chainlink/integration-tests/contracts/ccipreader_test.go: /home/runner/work/chainlink/chainlink/integration-tests/contracts/ccipreader_test.go:1026:54: missing ',' in composite literal (and 123 more errors)
##[error]Error: error mapping test results to paths: error parsing file /home/runner/work/chainlink/chainlink/integration-tests/contracts/ccipreader_test.go: /home/runner/work/chainlink/chainlink/integration-tests/contracts/ccipreader_test.go:1026:54: missing ',' in composite literal (and 123 more errors)
##[error]Error: error mapping test results to paths: error parsing file /home/runner/work/chainlink/chainlink/integration-tests/contracts/ccipreader_test.go: /home/runner/work/chainlink/chainlink/integration-tests/contracts/ccipreader_test.go:1026:54: missing ',' in composite literal (and 123 more errors)
##[error]Error: error mapping test results to paths: error parsing file /home/runner/work/chainlink/chainlink/integration-tests/contracts/ccipreader_test.go: /home/runner/work/chainlink/chainlink/integration-tests/contracts/ccipreader_test.go:1026:54: missing ',' in composite literal (and 123 more errors)
##[error]Error: error mapping test results to paths: error parsing file /home/runner/work/chainlink/chainlink/integration-tests/contracts/ccipreader_test.go: /home/runner/work/chainlink/chainlink/integration-tests/contracts/ccipreader_test.go:1026:54: missing ',' in composite literal (and 123 more errors)
##[error]Error: error mapping test results to paths: error parsing file /home/runner/work/chainlink/chainlink/integration-tests/contracts/ccipreader_test.go: /home/runner/work/chainlink/chainlink/integration-tests/contracts/ccipreader_test.go:1026:54: missing ',' in composite literal (and 123 more errors)
##[error]Error: error mapping test results to paths: error parsing file /home/runner/work/chainlink/chainlink/integration-tests/contracts/ccipreader_test.go: /home/runner/work/chainlink/chainlink/integration-tests/contracts/ccipreader_test.go:1026:54: missing ',' in composite literal (and 123 more errors)
##[error]Error: error mapping test results to paths: error parsing file /home/runner/work/chainlink/chainlink/integration-tests/contracts/ccipreader_test.go: /home/runner/work/chainlink/chainlink/integration-tests/contracts/ccipreader_test.go:1026:54: missing ',' in composite literal (and 123 more errors)
##[error]Error: error mapping test results to paths: error parsing file /home/runner/work/chainlink/chainlink/integration-tests/contracts/ccipreader_test.go: /home/runner/work/chainlink/chainlink/integration-tests/contracts/ccipreader_test.go:1026:54: missing ',' in composite literal (and 123 more errors)
##[error]Error: error mapping test results to paths: error parsing file /home/runner/work/chainlink/chainlink/integration-tests/contracts/ccipreader_test.go: /home/runner/work/chainlink/chainlink/integration-tests/contracts/ccipreader_test.go:1026:54: missing ',' in composite literal (and 123 more errors)
**Why**: The error indicates that the column `parent_block_hash` does not exist in the `log_poller_blocks` table, which is required by the test `TestDatabaseBackFillWithMigration202`.

Suggested fix: Ensure that the parent_block_hash column is added to the log_poller_blocks table before running the test. This might involve updating the migration scripts to include this column.

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
C Security Rating on New Code (required ≥ A)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant