Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup ci-core #15779

Merged
merged 5 commits into from
Jan 2, 2025
Merged

chore: cleanup ci-core #15779

merged 5 commits into from
Jan 2, 2025

Conversation

erikburt
Copy link
Collaborator

@erikburt erikburt commented Dec 19, 2024

Changes

  • Remove workflow_dispatch trigger inputs as they are so infrequently used.
  • Carve out flakeguard jobs to own workflow
  • Remove flaky test detector
  • Cleanup run conditions
  • Remove unused conditions for clean/tidy job

Motivation

Cleaning up the workflow to logically separate functionality. Flakeguard in CI-Core was only running on pull-request and it wasn't necessary to have there.

Removing flaky test detector, flakeguard now handles all metrics and is a much more elegant solution.


RE-3323

@erikburt erikburt self-assigned this Dec 19, 2024
@erikburt erikburt marked this pull request as ready for review December 20, 2024 21:49
@erikburt erikburt requested review from a team as code owners December 20, 2024 21:49
@smartcontractkit smartcontractkit deleted a comment from github-actions bot Dec 20, 2024
scheibinger
scheibinger previously approved these changes Dec 23, 2024
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@erikburt erikburt added this pull request to the merge queue Jan 2, 2025
Merged via the queue into develop with commit 945c706 Jan 2, 2025
101 of 102 checks passed
github-merge-queue bot pushed a commit that referenced this pull request Jan 2, 2025
* chore: cleanup ci-core

* chore: rename Flakeguard workflow
@erikburt erikburt deleted the chore/cleanup-ci-core branch January 2, 2025 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants