[CRE-42] Fix partial or truncated writes #989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krehermann
previously approved these changes
Jan 9, 2025
| @@ -553,29 +553,43 @@ func Test_read(t *testing.T) { | |||
| } | |||
|
|
|||
| func Test_write(t *testing.T) { | |||
| t.Run("successfully write to slice", func(t *testing.T) { | |||
| t.Run("OK-successfully_write_to_slice", func(t *testing.T) { | |||
There was a problem hiding this comment.
these OK/NOK are out of character with the rest of the code base; recommend removing them
and, there is no need to explicitly underscore the names; the go tooling does it under the hood
krehermann
approved these changes
Jan 9, 2025
cedric-cordenier
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fix validates that the size specified matches the actual length of the data being written in order to avoid partial/truncated writes or unwanted data if the size is bigger than the actual data written. More info on the ticket
CRE-42
Requires
Supports