INFOPLAT-1562 dynamic expiring auth headers #974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hendoxc
had a problem deploying
to
integration
GitHub Actions
Failure
cll-gg
reviewed
Dec 16, 2024
cll-gg
reviewed
Dec 16, 2024
cll-gg
reviewed
Dec 16, 2024
4of9
reviewed
Dec 16, 2024
- Adds function for signing publickey + timestamp. - Adjusts `BuildAuthHeaders` to take variadic args allowing backwards compatibiilty INFOPLAT-1559 Fixes some lint issues INFOPLAT-1559 Handles edge case of negative timestamps INFOPLAT-1559 Switches to exposing new function - go recommended way to add extend a function - added Config as 2nd arg as opposed to optional args INFOPLAT-1559 Adjusts `authHeaderVersion2` - minor refactor of test INFOPLAT-1559 Tightens time range for test Update pkg/beholder/auth.go Co-authored-by: 4of9 <[email protected]>
- allows for dynamic headers auth tokens to be used in GRPC request headers - auto refreshes the token on interval
…c `AuthHeaders` Need this for migration of existing usage - current users of beholder can still use never verions while using static headers, but can make the switch across to setting `AuthHeaderProvider`
hendoxc
force-pushed
the
INFOPLAT-1562-dynamic-expiring-auth-headers
branch
from
2ed4940 to
e40e8fd
Compare
hendoxc
had a problem deploying
to
integration
GitHub Actions
Failure
bit more clear conceptually
protects against concurrent calls of `refresh` INFOPLAT-1560 Makes `refresh` thread safe
…Credentials refresh logic
jmank88
reviewed
Dec 18, 2024
- uses method for construction
4of9
previously approved these changes
Dec 19, 2024
pkcll
reviewed
Dec 20, 2024
pkg/beholder/client.go
Outdated
| otlpmetricgrpc.WithHeaders(config.AuthHeaders), | ||
| } | ||
| if config.AuthHeaderProvider != nil { | ||
| opts = append(opts, otlpmetricgrpc.WithDialOption(grpc.WithPerRPCCredentials(config.AuthHeaderProvider.Credentials()))) |
There was a problem hiding this comment.
It seems there should be a relationship between otlpmetricgrpc.WithTLSCredentials (line 355, set based on config.InsecureConnection option) and
config.AuthHeaderProvider.Credentials().RequireTransportSecurity
If TLS is enabled AuthHeaderProvider.Credentials().RequireTransportSecurity()should always return true.
Im wondering whats the good way to handle that?
There was a problem hiding this comment.
Lets test what happens when RequireTransportSecurity and InsecureConnection mismatch.
pkcll
reviewed
Dec 20, 2024
pkg/beholder/client.go
Outdated
| otlploggrpc.WithHeaders(cfg.AuthHeaders), | ||
| } | ||
| if cfg.AuthHeaderProvider != nil { | ||
| opts = append(opts, otlploggrpc.WithDialOption(grpc.WithPerRPCCredentials(cfg.AuthHeaderProvider.Credentials()))) |
pkcll
previously approved these changes
Dec 20, 2024
if Config.InsecureConnection is `false` we should ensure that we set our `PerRPCCredentials` implementation to return true for `RequireTransportSecurity` While `RequireTransportSecurity` can be set on AuthHeaderProvider initiailzation, its not required, this can lead to a mismatch in configurations, this adds a guard to prevent this from happening
pkcll
previously approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INFOPLAT-1560
What
Allows usage of dynamic auth headers by implementing
grpc.PerRPCCredentials& setting as aDialOptionon the otel clientWhy
Makes tokens expire, in the case that one is leaked or intercepted.
2tokens have their timestamp part checkedtime.Now > timestamp > time.Now - serverTTLNotes
Current users of the client can still configure static headers using the
AuthHeadersfield of beholder clientConfig. To enable dynamic headers they instead should configureAuthHeaderProvider