Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update head data to be optional #898

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

update head data to be optional #898

wants to merge 2 commits into from

Conversation

ettec
Copy link
Contributor

@ettec ettec commented Oct 29, 2024 •
edited
Loading

The underlying head tracker returns a pointer to head data, this updates the GetLatestValueWithHeadData to do the same. Also, implements the loop logic for the GetLatestValueWithHeadData API method.

@ettec ettec requested a review from a team as a code owner October 29, 2024 11:25
@ettec ettec requested review from vyzaldysanchez and removed request for a team October 29, 2024 11:25
ilija42
ilija42 previously approved these changes Oct 29, 2024
View reviewed changes
@ettec ettec mentioned this pull request Oct 29, 2024
Open
ilija42
ilija42 requested changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@ilija42 ilija42 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look at TestGetLatestValue in pkg/loop/internal/relayer/pluginprovider/contractreader/contract_reader_test.go, this method should have similar tests

ilija42
ilija42 requested changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@ilija42 ilija42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a test failure

@ettec ettec force-pushed the update-contract-reader-interface branch from c198e34 to 71eeb05 Compare October 30, 2024 15:10
@ettec ettec force-pushed the update-contract-reader-interface branch from 71eeb05 to d9445ab Compare October 31, 2024 09:41
@ettec ettec force-pushed the update-contract-reader-interface branch from d9445ab to 6effcf1 Compare October 31, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyzaldysanchez vyzaldysanchez vyzaldysanchez approved these changes

@ilija42 ilija42 Awaiting requested review from ilija42

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ettec @vyzaldysanchez @ilija42