Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code generators to help build workflows #704

Merged
merged 19 commits into from
Aug 21, 2024
Merged

Add code generators to help build workflows #704

merged 19 commits into from
Aug 21, 2024

Conversation

nolag
Copy link
Collaborator

@nolag nolag commented Aug 14, 2024

Last part taken from this PR

@nolag nolag requested review from a team as code owners August 14, 2024 14:48
@nolag nolag force-pushed the rtinianov_builders branch from 3ab8678 to 16b6be2 Compare August 14, 2024 14:49
Base automatically changed from rtinianov_jsonschemas to main August 14, 2024 15:09
@nolag nolag force-pushed the rtinianov_builders branch from 16b6be2 to 82d4134 Compare August 14, 2024 15:22
@DeividasK
Copy link
Collaborator

It might make sense to have tests for the generators so the edge cases are covered (I'm not sure if you plan to do a builder for every possible combination).

pkg/values/value.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@DeividasK DeividasK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving on the assumption that you'll add a test in a follow-up PR.

@nolag nolag merged commit 07e3b04 into main Aug 21, 2024
9 of 11 checks passed
@nolag nolag deleted the rtinianov_builders branch August 21, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants