pkg/loop: plugins report health to host [BCF-2709] #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmank88
force-pushed
the
BCF-2709-loop-plugin-health
branch
from
db7e8af to
51cc19d
Compare
jmank88
force-pushed
the
BCF-2709-loop-plugin-health
branch
from
51cc19d to
f22f854
Compare
jmank88
changed the title
jmank88
force-pushed
the
BCF-2709-loop-plugin-health
branch
from
f22f854 to
c2c5209
Compare
jmank88
had a problem deploying
to
integration
GitHub Actions
Failure
jmank88
had a problem deploying
to
integration
GitHub Actions
Failure
jmank88
had a problem deploying
to
integration
GitHub Actions
Failure
jmank88
force-pushed
the
BCF-2709-loop-plugin-health
branch
from
c2c5209 to
6ef2e4a
Compare
jmank88
had a problem deploying
to
integration
GitHub Actions
Failure
jmank88
had a problem deploying
to
integration
GitHub Actions
Failure
jmank88
had a problem deploying
to
integration
GitHub Actions
Failure
jmank88
force-pushed
the
BCF-2709-loop-plugin-health
branch
from
6ef2e4a to
1484a99
Compare
jmank88
had a problem deploying
to
integration
GitHub Actions
Failure
jmank88
had a problem deploying
to
integration
GitHub Actions
Failure
jmank88
force-pushed
the
BCF-2709-loop-plugin-health
branch
from
1484a99 to
e443f8f
Compare
jmank88
had a problem deploying
to
integration
GitHub Actions
Failure
jmank88
had a problem deploying
to
integration
GitHub Actions
Failure
jmank88
force-pushed
the
BCF-2709-loop-plugin-health
branch
from
e443f8f to
86072cd
Compare
jmank88
commented
Jan 14, 2025
|
|
||
| hr := map[string]error{s.Name(): s.Healthy()} | ||
|
|
||
| // wait until service is ready, which also triggers the deferred construction to ensure a complete HealthReport |
There was a problem hiding this comment.
This works, but it feels hacky 🤔
There was a problem hiding this comment.
seems reasonable to me. we either have to pull or push; changing to push would be a lot of work for little gain afaict
jmank88
force-pushed
the
BCF-2709-loop-plugin-health
branch
from
6098284 to
22774c5
Compare
jmank88
force-pushed
the
BCF-2709-loop-plugin-health
branch
from
22774c5 to
7938700
Compare
| serviceCh chan struct{} // closed when service is available | ||
| Service S | ||
| serviceCh chan struct{} // closed when service is available | ||
| Service S |
There was a problem hiding this comment.
Do S and HealthReport needed to be synchronously closed when PluginService is closed?
There was a problem hiding this comment.
It shouldn't really matter 🤔
There was a problem hiding this comment.
Of course if we have log noise or something then that is worth addressing.
There was a problem hiding this comment.
Or log after a test close
jmank88
force-pushed
the
BCF-2709-loop-plugin-health
branch
from
7938700 to
40b2af1
Compare
patrickhuie19
approved these changes
Jan 15, 2025
krehermann
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://smartcontract-it.atlassian.net/browse/BCF-2709
This change makes the top level plugin types
services.Services in order to report plugin health back through the host.It also introduces testing helpers for verifying service names from health reports and log lines.
Requires:
Supports: