Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ledger sign command #8

Merged
merged 35 commits into from
Sep 30, 2024
Merged

Add ledger sign command #8

merged 35 commits into from
Sep 30, 2024

Conversation

akhilchainani
Copy link
Collaborator

@akhilchainani akhilchainani commented Aug 27, 2024 •
edited by connorwstein
Loading

Notes

  • Moving commands to CLD binary
    • Note dropped the cli assertions tests. They seem like limited value currently, maybe can add them back later if desired

@akhilchainani akhilchainani changed the base branch from feat/tooling-library to feat/signing-tools September 10, 2024 16:47
@akhilchainani akhilchainani changed the base branch from feat/signing-tools to develop September 18, 2024 17:59
@akhilchainani akhilchainani marked this pull request as ready for review September 18, 2024 18:40
@connorwstein connorwstein merged commit fc29354 into develop Sep 30, 2024
1 check passed
@connorwstein connorwstein deleted the feat/tooling-lib-with-ledger branch September 30, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmalec cmalec cmalec approved these changes

@0xAustinWang 0xAustinWang Awaiting requested review from 0xAustinWang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akhilchainani @cmalec @connorwstein