Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce SmallRyeConfig.subset #983

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Introduce SmallRyeConfig.subset #983

wants to merge 1 commit into from

Conversation

gastaldi
Copy link
Contributor

@gastaldi
Copy link
Contributor Author

/cc @dmlloyd @radcortez

@gastaldi gastaldi force-pushed the subset branch 3 times, most recently from 71a57e5 to 3e9f521 Compare August 24, 2023 16:32
dmlloyd
dmlloyd requested changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@dmlloyd dmlloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd only make one change for now (make the implementation class non-public). There are a few other places which could be more optimal given some internal architecture changes (specifically, iterating the nested keys).

implementation/src/main/java/io/smallrye/config/SmallRyeSubsetConfig.java Outdated Show resolved Hide resolved
@gastaldi gastaldi force-pushed the subset branch 4 times, most recently from 58332c0 to 5b46b0c Compare August 24, 2023 16:41
@gastaldi gastaldi requested a review from dmlloyd August 24, 2023 16:43
dmlloyd
dmlloyd previously approved these changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@dmlloyd dmlloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if @radcortez is OK with it.

@gastaldi gastaldi requested a review from dmlloyd August 24, 2023 16:55
@gastaldi
Copy link
Contributor Author

Pushed a small fix that filters out properties that don't belong to the subset

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmlloyd dmlloyd Awaiting requested review from dmlloyd

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support subsets from a Config
2 participants
@gastaldi @dmlloyd