Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editorial: Clarify DependencyLevels, SlsaResult, and quote level keys. #988

Merged

Conversation

AdamZWu
Copy link
Contributor

@AdamZWu AdamZWu commented Oct 13, 2023

This is related to issues #968, just a cleanup preparing the proposal to remove "FAILED" at v1.1 in a future commit.

@netlify
Copy link

netlify bot commented Oct 13, 2023

Deploy Preview for slsa ready!

Name Link
🔨 Latest commit 0f57f4a
🔍 Latest deploy log https://app.netlify.com/sites/slsa/deploys/65367421f3e60100070a2634
😎 Deploy Preview https://deploy-preview-988--slsa.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@AdamZWu
Copy link
Contributor Author

AdamZWu commented Oct 13, 2023

Oh, hold on. SLSA_BUILD_LEVEL_UNEVALUATED got leaked from v1.1 into v1.0.
Let me fix that.

@AdamZWu AdamZWu force-pushed the ZhenyuWu-vsa-v1_0_vsa_level_editing branch from 5a76d99 to fd2a5e2 Compare October 13, 2023 13:58
Copy link
Member

@MarkLodato MarkLodato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

docs/spec/v1.0/verification_summary.md Outdated Show resolved Hide resolved
docs/spec/v1.0/verification_summary.md Outdated Show resolved Hide resolved
docs/spec/v1.0/verification_summary.md Outdated Show resolved Hide resolved
@AdamZWu AdamZWu requested a review from MarkLodato October 20, 2023 22:22
@AdamZWu AdamZWu force-pushed the ZhenyuWu-vsa-v1_0_vsa_level_editing branch 2 times, most recently from 5e6a43e to f400a63 Compare October 20, 2023 22:24
@AdamZWu AdamZWu force-pushed the ZhenyuWu-vsa-v1_0_vsa_level_editing branch from f400a63 to 0f57f4a Compare October 23, 2023 13:24
Copy link
Member

@MarkLodato MarkLodato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @AdamZWu

Copy link
Member

@lehors lehors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@trishankatdatadog trishankatdatadog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@MarkLodato MarkLodato merged commit efce54f into slsa-framework:main Nov 17, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants