Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct sidebar links on provenance page #1260

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

arewm
Copy link
Member

@arewm arewm commented Dec 13, 2024

When clicking on Schema.Builder, the anchor would go to the table row with the builder ID instead of the builder heading. This should deconflict the anchor points to make the sidebar correctly point to the right place on the page.

The change also makes the tr ids consistent for the RunDetails section.

When clicking on Schema.Builder, the anchor would go to the table row
with the builder ID instead of the builder heading. This should
deconflict the anchor points to make the sidebar correctly point to the
right place on the page.

The change also makes the tr ids consistent for the RunDetails section.

Signed-off-by: arewm <[email protected]>
Copy link

netlify bot commented Dec 13, 2024

Deploy Preview for slsa ready!

Name Link
🔨 Latest commit 6efa10d
🔍 Latest deploy log https://app.netlify.com/sites/slsa/deploys/675c7511b728ae0008e811a2
😎 Deploy Preview https://deploy-preview-1260--slsa.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@arewm
Copy link
Member Author

arewm commented Dec 13, 2024

This is the properly behaving anchor: https://deploy-preview-1260--slsa.netlify.app/spec/v1.0/provenance#builder

Copy link
Contributor

@TomHennen TomHennen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding/fixing this. :)

docs/spec/draft/provenance.md Outdated Show resolved Hide resolved
docs/spec/v1.0/provenance.md Outdated Show resolved Hide resolved
docs/spec/v1.1/provenance.md Outdated Show resolved Hide resolved
Co-authored-by: Tom Hennen <[email protected]>
Signed-off-by: Andrew McNamara <[email protected]>
@arewm arewm merged commit cf26ea9 into slsa-framework:main Dec 13, 2024
6 checks passed
@arewm arewm deleted the fix-provenance-schema-links branch December 13, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants