Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

content: draft: Add attested build environment track #1115

Merged

Conversation

marcelamelara
Copy link
Contributor

@marcelamelara marcelamelara commented Aug 15, 2024

This PR introduces the following spec changes associated with #975. The spec enhancements are being proposed as the new "build Environment track".

Spec changes: Adds new high-level build environment terminology and levels.

Part 1 of #975 CC @paveliak

Copy link

netlify bot commented Aug 15, 2024

Deploy Preview for slsa ready!

Name Link
🔨 Latest commit e5eda5a
🔍 Latest deploy log https://app.netlify.com/sites/slsa/deploys/6709c2d9b982fd0008a8f368
😎 Deploy Preview https://deploy-preview-1115--slsa.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@marcelamelara marcelamelara force-pushed the attested-build-env-track branch 2 times, most recently from e505871 to 5a2a961 Compare August 15, 2024 23:36
@TomHennen
Copy link
Contributor

FYI if you want to make the linter happy easily this might help. The linter caused me a ton of trouble until I figured this out.

Copy link
Contributor

@TomHennen TomHennen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like where this is heading :)

docs/spec/draft/attested-build-env-levels.md Outdated Show resolved Hide resolved
docs/spec/draft/attested-build-env-levels.md Outdated Show resolved Hide resolved
docs/spec/draft/attested-build-env-levels.md Outdated Show resolved Hide resolved
docs/spec/draft/attested-build-env-levels.md Outdated Show resolved Hide resolved
docs/spec/draft/attested-build-env-levels.md Outdated Show resolved Hide resolved
@marcelamelara marcelamelara changed the title content: Attested build environment track content: Add attested build environment track Aug 16, 2024
@marcelamelara marcelamelara force-pushed the attested-build-env-track branch from cbf816f to 7a39858 Compare August 16, 2024 22:28
@marcelamelara marcelamelara self-assigned this Aug 20, 2024
@marcelamelara marcelamelara added the build-environment-track Issues/PRs related to the SLSA BuildEnv track label Aug 20, 2024
@marcelamelara marcelamelara force-pushed the attested-build-env-track branch 2 times, most recently from dbc5dd1 to 8846927 Compare September 4, 2024 23:34
@marcelamelara marcelamelara force-pushed the attested-build-env-track branch 2 times, most recently from 8df324b to 08b92e8 Compare September 18, 2024 00:37
@marcelamelara marcelamelara marked this pull request as ready for review September 18, 2024 00:39
@marcelamelara marcelamelara requested review from a team, TomHennen and paveliak September 18, 2024 00:39
Copy link
Contributor

@TomHennen TomHennen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these changes!

This generally LGTM, I would also like to see what @deeglaze thinks about it too.

docs/spec/draft/attested-build-env-levels.md Outdated Show resolved Hide resolved
docs/spec/draft/attested-build-env-levels.md Outdated Show resolved Hide resolved
docs/spec/draft/attested-build-env-levels.md Outdated Show resolved Hide resolved
docs/spec/draft/attested-build-env-levels.md Outdated Show resolved Hide resolved
docs/spec/draft/attested-build-env-levels.md Show resolved Hide resolved
docs/spec/draft/attested-build-env-levels.md Show resolved Hide resolved
docs/spec/draft/attested-build-env-levels.md Show resolved Hide resolved
docs/spec/draft/attested-build-env-levels.md Outdated Show resolved Hide resolved
docs/spec/draft/attested-build-env-levels.md Outdated Show resolved Hide resolved
docs/spec/draft/attested-build-env-levels.md Outdated Show resolved Hide resolved
docs/spec/draft/attested-build-env-levels.md Outdated Show resolved Hide resolved
docs/spec/draft/attested-build-env-levels.md Outdated Show resolved Hide resolved
docs/spec/draft/attested-build-env-levels.md Outdated Show resolved Hide resolved
docs/spec/draft/attested-build-env-levels.md Outdated Show resolved Hide resolved
docs/spec/draft/attested-build-env-levels.md Outdated Show resolved Hide resolved
marcelamelara and others added 10 commits October 11, 2024 11:36
Signed-off-by: Marcela Melara <[email protected]>
Signed-off-by: Marcela Melara <[email protected]>
Signed-off-by: Marcela Melara <[email protected]>
Signed-off-by: Marcela Melara <[email protected]>
Co-authored-by: Dionna Amalie Glaze <[email protected]>
Signed-off-by: Marcela Melara <[email protected]>
@marcelamelara marcelamelara force-pushed the attested-build-env-track branch from 4610a2c to c0c8105 Compare October 11, 2024 18:36
marcelamelara and others added 2 commits October 11, 2024 17:27
Co-authored-by: Andrew McNamara <[email protected]>
Signed-off-by: Marcela Melara <[email protected]>
Copy link
Contributor

@TomHennen TomHennen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an amazing start.

I think we can continue to iterate on this draft in other issues & PRs.

Thanks Marcela!

@TomHennen TomHennen changed the title content: Add attested build environment track content: draft: Add attested build environment track Oct 15, 2024
@TomHennen
Copy link
Contributor

FYI updated title to indicate this is draft!

Copy link
Member

@arewm arewm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this draft content. Many of the topics that I have raised have moved to issues. Partially for my reference (because there were so many threads), I think the conversation has moved here:

@marcelamelara marcelamelara merged commit cc81626 into slsa-framework:main Oct 21, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build-environment-track Issues/PRs related to the SLSA BuildEnv track
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

9 participants