Skip to content

Commit

Permalink
edit comment into a TODO
Browse files Browse the repository at this point in the history
Signed-off-by: Ramon Petgrave <[email protected]>
  • Loading branch information
ramonpetgrave64 committed Apr 16, 2024
1 parent ee33086 commit 2456885
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion verifiers/internal/gha/npm_sigstore_tuf.go
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,8 @@ func getNpmjsKeysTarget(client sigstoreTufClient, targetPath string) (*npmjsKeys
}

// getKeyDataWithNpmjsKeysTarget returns the target key's material, given our set of keys, return the target key's material.
// We may also want to check the existing ValidFor.Start (and a potential future ValidFor.End).
// TODO: We may also want to check the existing ValidFor.Start (and a potential future ValidFor.End).
// https://github.com/slsa-framework/slsa-verifier/issues/757
func getKeyDataWithNpmjsKeysTarget(keys *npmjsKeysTarget, keyID, keyUsage string) (string, error) {
for _, key := range keys.Keys {
if key.KeyID == keyID && key.KeyUsage == keyUsage {
Expand Down

0 comments on commit 2456885

Please sign in to comment.