Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Governance improvements #24

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 23 additions & 16 deletions 5._Governance.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,57 +6,64 @@ As a community effort organized within the [Supply Chain Integrity WG](https://g

The SLSA Project described in this document is the "Working Group" for purposes of the [Community Specification License 1.0](./1._Community_Specification_License-v1.md).

The SLSA Project is comprised of multiple "Workstreams." These Workstreams represent different tracks of specification work or tools implementation. Workstreams are not strictly tied to unique repositories in the slsa-framework GitHub organization.

## 1. Roles.

The Project includes the following roles. Additional roles may be adopted and documented by the Steering Committee.

**1.1. Participants.** "Participants" are those that have (a) made Contributions to the Project subject to the Community Specification License; (b) contributed code or documentation to Project assets other than specifications; and/or (c) otherwise contributed to or participated in the SLSA community, such as by attending meetings.
**1.1. Participants.** "Participants" are those that have contributed to or participated in the SLSA community, such as by attending meetings, engaging in conversations on Slack, or commenting on documents.
TomHennen marked this conversation as resolved.
Show resolved Hide resolved

**1.2. Contributors.** "Contributors" are those Participants that have (a) made Contributions to the Project subject to the Community Specification License; and/or (b) contributed code or documentation to Project assets other than specifications.
**1.2. Contributors.** "Contributors" are those Participants that have (a) made Contributions to the Project and/or (b) contributed code or documentation to Project assets other than specifications. E.g. creating a PR, reviewing a PR, and editing a specification in a document.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**1.2. Contributors.** "Contributors" are those Participants that have (a) made Contributions to the Project and/or (b) contributed code or documentation to Project assets other than specifications. E.g. creating a PR, reviewing a PR, and editing a specification in a document.
**1.2. Contributors.** "Contributors" are those Participants that have (a) made Contributions to the Project and/or (b) contributed code or documentation to Project assets other than specifications. E.g. creating a PR, reviewing a PR, and editing a specification in a document.

the "other than specifications" seems odd here. I know you didn't add it, but it feels out of place when reading the new description.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not seeing the diff, did you want us to remove other than specifications?


**1.3. Maintainers.** "Maintainers" are responsible for reviewing and merging all proposed changes, and they guide the overall technical direction of the Project within the guidelines established by the Steering Committee. The "Specification Maintainers" are the default set of Maintainers for all Project repositories, recorded in slsa.git's [MAINTAINERS.md](https://github.com/slsa-framework/slsa/blob/main/MAINTAINERS.md). Other Project repositories may have a distinct set of Maintainers, defined in their respective MAINTAINERS.md files.
**1.3. Maintainers.** "Maintainers" are responsible for reviewing and merging all proposed changes, and they guide the overall technical direction of a Workstream within the guidelines established by the Steering Committee. Each Workstream will record its Maintainers in a MAINTAINERS.md file in the appropriate repositories + path locations.

Maintainers may be added through majority approval of existing Maintainers, based on the following criteria:

* Demonstrated track record of PR reviews (both quality and quantity of reviews)
* Demonstrated thought leadership in the project
* Demonstrated shepherding of project work and contributors

Maintainers may be removed by explicit resignation, for prolonged inactivity (e.g. 3 or more months with no review comments), for some infraction of the code of conduct, or by consistently demonstrating poor judgment. A proposed removal also requires a majority approval. A Maintainer removed for inactivity should be restored following a sustained resumption of contributions and reviews (a month or more) demonstrating a renewed commitment to the project.
Maintainers may be removed by explicit resignation, for prolonged inactivity (e.g. 3 or more months with no review comments), for some infraction of the code of conduct, or for consistently demonstrating poor judgment. A proposed removal also requires a majority approval. A Maintainer removed for inactivity may be restored following a sustained resumption of contributions and reviews (a month or more) demonstrating a renewed commitment to the project.

In the extreme event that a majority of existing Maintainers are unavailable to approve additions or removals for an extended period of time, the Steering Committee may add or remove Maintainers to bring the Project back to a functioning state.

<!-- Note: The above text was copied with modification from https://github.com/hyperledger/fabric/blob/main/docs/source/CONTRIBUTING.rst -->

**1.4. Steering Committee Members.** The "Steering Committee" is the body that is responsible for overseeing the overall activities of the Project. The Steering Committee consists of up to 7 Participants (each, a "Steering Committee Member") and will initially consist of the Steering Committee Members so designated as of the date of initial adoption of this SLSA Governance Policy. The Steering Committee will meet regularly as needed, but no less then once per quarter. Examples of the responsibilities of the Steering Committee include:
**1.4. Steering Committee Members.** The "Steering Committee" is the body that is responsible for overseeing the overall activities of the Project. The Steering Committee consists of 5 Participants (each, a "Steering Committee Member") and will initially consist of the Steering Committee Members so designated as of the date of initial adoption of this SLSA Governance Policy. The Steering Committee will meet regularly as needed, but no less then once per quarter. Examples of the responsibilities of the Steering Committee include:

* enabling the smooth running of the Project
* coordinating activities between workstreams and Maintainers
* collectively reviewing and revising the roadmap on a biannual basis
* collectively reviewing and revising the Project mission, vision, strategy, and roadmap every 6 months or more frequently if needed, and publishing Steering Committee meetings notes
* publishing quarterly updates suitable for OpenSSF TAC and other working groups' consumption
* participating in strategic planning, such as coordinating face-to-face meetings or suggesting and approving changes to the governance model
* creating or restructuring workstreams
* managing the lifecycle of existing and proposed Workstreams within the Project with the consensus input from the community of Participants
* creating or restructuring Workstreams
* responding to specific issues or concerns above and beyond the domain of the various workstreams
* making decisions when community consensus cannot be reached, pursuant to the appeal process documented below
* holding Maintainers accountable to the standards of what makes SLSA an effective Project and representative of a diverse community of Participants and Contributors. In the extreme event that a majority of existing Maintainers are unavailable to approve additions or removals for an extended period of time, the Steering Committee may add or remove Maintainers to bring the Project back to a functioning state
michaelwinser marked this conversation as resolved.
Show resolved Hide resolved
* administration of slsa-framework GitHub organization, including maintaining team memberships for Maintainers, setting security defaults such as branch protection for the organization, managing secrets, etc.


**1.5. Steering Committee Member Terms.** During the initial year, the Steering Committee Members will agree on grouping themselves into two groups, one to serve an initial two-year term, and the other for an initial one-year term. Thereafter, the Steering Committee Members will serve two year terms.
**1.5. Steering Committee Member Terms.** Steering Committee Members have a one year term.
TomHennen marked this conversation as resolved.
Show resolved Hide resolved
One month before the expiration of a Steering Committee Member term, any Participant may submit a nomination to fill the seat. A Participant must include the following documentation in their nomination:

At the expiration of a Steering Committee Member term, any Participant may submit a nomination to fill the seat. An individual may be nominated for and serve any number of successive terms.
* Statement of intent to perform the duties of a Steering Committee Member during the next term
* Evidence of active participation in the community and being well-versed in SLSA
* Affiliation / employer

If a Steering Committee Member resigns or ceases to participate for a significant period of time prior to the end of their term, the remaining Steering Committee Members may choose to remove that Steering Committee Member. If so, the remaining Steering Committee Members will determine whether and when to fill the role.
An individual may be nominated for and serve any number of successive terms. However, Steering Committee Members are encouraged to allow other longstanding Participants to contribute as Steering Committee Members. Steering Committee Members are elected by current Participants. Steering Committee Members must resign if they become inactive. Steering Committee Members may be removed in extraordinary circumstances with an escalation to the OpenSSF TAC.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inactive

is this defined formally anywhere?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, we had talked previously around having the steering committee maybe having their own meeting but we found that those meetings don't really address anything that isn't in the spec meeting so I think the idea here should be the same rules as participation with some time limit, e.g. expectations that they are participating in some capacity monthly?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we define inactivity as not performing the duties as stated in 1.4, do you think that is sufficient? To address not being present in meetings, we could add a duty of "active participation in weekly community meetings"?

I'm hesitant to say monthly or any time period to avoid being able to game this, e.g. show up exactly once a month.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dislike meeting attendance as the criteria for activity. I know it reflects how the project runs at present, but want to register my dismay that this excludes folks who can't make the weekly meeting.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree: it's hard to be there for all the meetings, and maybe some folks are more active in PRs (which I think matter more) than meetings.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about phrasing this as "active participation with the community"? I recognize that the meeting might not work for all timezones, but I think there are still ways to be an active leader in the community - regular interactions over issues and Slack, leaving comments on the community meeting doc, outreach at conferences, etc.

Activity on PRs can be one component of active participation, but not the only component in my opinion, as that would be more of a Maintainer.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as the OSSF TAC can use the new phrasing for fair adjudication, sounds reasonable to me.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "any number of successive terms" is a bit problematic. Could we limit to, say, 4 years (like a presidential term) and go from there?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do encourage stepping down if you're a longstanding member.

If there is someone who is an exceptional SLSA leader and continually voted in by the community, is that a problem?


The Steering Committee may add additional Steering Committee Members as it deems necessary.
Nominations and decisions must be publicly recorded, e.g. on GitHub issues or Slack, for transparency.

After discussion with the nominees for a vacant seat, the Steering Committee will select the new Steering Committee Members from the group of nominees taking into account such things as the nominees’ willingness to take on the role, skills, and level of participation as well as the need to maintain a balanced perspective on the Steering Committee (e.g., no more than two people from the same group of related companies should be on the Steering Committee). A Steering Committee Member nominee may not deliberate or vote on their own appointment.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove the bit about not voting for self? Well, I guess going by presidential elections...

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the context of this paragraph, not voting for yourself as important because it was only the steering committee who elects its own members. I don't see an issue with voting for yourself along with the other 4 members given it will be the whole SLSA community voting. (FWIW, this line was not intentionally removed, it was a part of removing the entire paragraph)


## 2. Decision Making.

**2.1. Consensus-Based Decision Making.** The Project makes decisions through a consensus process ("Approval" or "Approved"). While the agreement of all applicable Participants is preferred, it is not required for consensus. Rather, the Maintainers or Steering Committee (as applicable) will determine consensus based on their good faith consideration of a number of factors, including the dominant view of the applicable Project Participants and nature of support and objections. The Maintainers or Steering Committee (as applicable) will document evidence of consensus in accordance with these requirements.

**2.2. Appeal Process.** Decisions may be appealed be via a pull request or an issue, and that appeal will be considered by the applicable Maintainers in good faith, who will respond in writing within a reasonable time.
**2.2. Appeal Process.** Decisions may be appealed via a pull request or an issue, and that appeal will be considered by the applicable Maintainers in good faith, who will respond in writing within a reasonable time.

**2.3. Steering Committee Appeal Process.** Decisions that have been appealed to the Maintainers may in extraordinary cases be appealed to the Steering Committee for reconsideration. An appeal to the Steering Committee must specify in detail (1) the specific decision that is being appealed; (2) the basis for contending that the decision was not aligned with the purposes, goals or scope of the Project; and (3) an explanation of why the decision is extraordinary enough to warrant an appeal to the Steering Committee. The appeal will be considered by the Steering Committee in good faith, who will respond in writing within a reasonable time. The Steering Committee may decline to consider appeals that are unexceptional, unfounded or excessive, including because of their repetitive character.

**2.4. Amendments to Governance Documents.** The documents in this Governance repository may be amended by a two-thirds vote of the entire Steering Committee and are subject to approval by The Linux Foundation. However, entries may be added to the Notices file in this Governance repository as described therein.
**2.4. Amendments to Governance Documents.** The documents in this Governance repository may be amended by four of the five Steering Committee Members and are subject to approval by The Linux Foundation. However, entries may be added to the Notices file in this Governance repository as described therein.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do we facilitate approval by the LF?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair question - @michaelwinser what do you think about changing this to explicitly say the LF can override any changes if necessary? I think that is more what is meant here - the project can self-govern, but the LF has authority to override.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why 4/5 and not 3/5?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I recall correctly, we were going with super majority, following the two-thirds requirement. 3 is simple majority, 5 is complete consensus, so 4 felt like a good compromise. @michaelwinser do you remember anything else?


## 3. Ways of Working.

michaelwinser marked this conversation as resolved.
Show resolved Hide resolved
Expand Down